.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd736b069b320a18476b30aea47639fb25f50110 commit bd736b069b320a18476b30aea47639fb25f50110 Author: erikchen <erikchen@chromium.org> Date: Tue Mar 08 23:47:39 2016 Prepare base/ for compilation with OS X 10.7 deployment target. Disable deprecation warnings for AuthorizationExecuteWithPrivileges, which has been deprecated since OS X 10.7. Update the forward declaration of -[NSEvent stage] to have the appropriate semantics. It was introduced in OS X 10.10.3. BUG= 592663 , 593133 Review URL: https://codereview.chromium.org/1773303002 Cr-Commit-Position: refs/heads/master@{#379969} [modify] https://crrev.com/bd736b069b320a18476b30aea47639fb25f50110/base/mac/authorization_util.mm [modify] https://crrev.com/bd736b069b320a18476b30aea47639fb25f50110/base/mac/sdk_forward_declarations.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b49b37f73d3ae1fe219937620aa1f1e6197095 commit 71b49b37f73d3ae1fe219937620aa1f1e6197095 Author: erikchen <erikchen@chromium.org> Date: Tue Mar 08 23:49:16 2016 Prepare ui/ module for compilation with OS X 10.7 deployment target. 1. Added utility methods ConvertPointFromWindowToScreen and ConvertPointFromScreenToWindow to replace deprecated methods convertBaseToScreen: and convertBaseFromScreen:. 2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor. The utility methods added in (1) will also be used extensively in the content/ and chrome/ modules. BUG= 592663 Review URL: https://codereview.chromium.org/1777653002 Cr-Commit-Position: refs/heads/master@{#379971} [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/app_list/cocoa/apps_search_box_controller.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/base/cocoa/cocoa_base_utils.h [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/base/cocoa/cocoa_base_utils.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/base/cocoa/command_dispatcher.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/base/layout_mac.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/base/test/ui_controls_mac.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/events/cocoa/events_mac_unittest.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/gfx/screen_mac.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/snapshot/snapshot_mac.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/views/cocoa/tooltip_manager_mac.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/views/cocoa/widget_owner_nswindow_adapter.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/views/controls/menu/menu_runner_impl_cocoa.mm [modify] https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095/ui/views/test/event_generator_delegate_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aef985913eecbaec3866825f4d502d96a321c2e commit 8aef985913eecbaec3866825f4d502d96a321c2e Author: erikchen <erikchen@chromium.org> Date: Wed Mar 09 01:50:34 2016 Prepare remoting/ for compilation with OS X 10.7 deployment target. Now that base/ compiles as a 64-bit target, there is no reason for remoting/ to duplicate logic. The logic in base/ has been updated to not emit compile warning when compiling with a OS X 10.7 deployment target. BUG= 592663 Review URL: https://codereview.chromium.org/1778763002 Cr-Commit-Position: refs/heads/master@{#380027} [modify] https://crrev.com/8aef985913eecbaec3866825f4d502d96a321c2e/remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm [modify] https://crrev.com/8aef985913eecbaec3866825f4d502d96a321c2e/remoting/host/mac/me2me_preference_pane.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51f7d244880eb22d403f2c9731c0e733541ab632 commit 51f7d244880eb22d403f2c9731c0e733541ab632 Author: erikchen <erikchen@chromium.org> Date: Fri Mar 11 05:19:17 2016 Prepare content/ module for compilation with OS X 10.7 deployment target. Replaced deprecated methods convertBaseToScreen: and convertBaseFromScreen: with ConvertPointFromWindowToScreen and ConvertPointFromScreenToWindow. Fixed a unit test in render_widget_host_view_mac_unittest.mm, and a real bug in web_contents_view_mac.mm. BUG= 592663 Review URL: https://codereview.chromium.org/1777483005 Cr-Commit-Position: refs/heads/master@{#380521} [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/web_contents/web_contents_view_mac.mm [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/web_contents/web_drag_dest_mac.mm [modify] https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632/content/browser/web_contents/web_drag_source_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39bbac875e4ee4f041058b95b03d4c2cc95c501 commit b39bbac875e4ee4f041058b95b03d4c2cc95c501 Author: erikchen <erikchen@chromium.org> Date: Fri Mar 11 05:39:05 2016 Prepare chrome/ for compilation with OS X 10.7 deployment target. Replaced deprecated methods convertBaseToScreen: and convertBaseFromScreen: with ConvertPointFromWindowToScreen and ConvertPointFromScreenToWindow. BUG= 592663 Review URL: https://codereview.chromium.org/1775223002 Cr-Commit-Position: refs/heads/master@{#380540} [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/app_menu/menu_tracked_button.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/autofill/autofill_details_container.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/base_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/framed_browser_window.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm [modify] https://crrev.com/b39bbac875e4ee4f041058b95b03d4c2cc95c501/chrome/test/base/interactive_test_utils_cocoa.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bea53f048244f5d6d117c5484733130d3248009 commit 7bea53f048244f5d6d117c5484733130d3248009 Author: erikchen <erikchen@chromium.org> Date: Fri Mar 11 18:34:59 2016 Remove references to CWNetwork. Chrome no longer supports OS X 10.6. BUG= 592663 Review URL: https://codereview.chromium.org/1776253002 Cr-Commit-Position: refs/heads/master@{#380677} [modify] https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009/components/wifi/wifi_service_mac.mm [modify] https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c519490e5d3dff205429762976cfb07065e0a307 commit c519490e5d3dff205429762976cfb07065e0a307 Author: erikchen <erikchen@chromium.org> Date: Wed Mar 16 23:55:35 2016 Suppress -Wdeprecated-declarations warnings in apple_keychain_mac.mm. This is required to update the deployment target to OS X 10.7. Eventually, the deprecated Keychain methods should be removed entirely. BUG= 595468 , 592663 Review URL: https://codereview.chromium.org/1813523002 Cr-Commit-Position: refs/heads/master@{#381593} [modify] https://crrev.com/c519490e5d3dff205429762976cfb07065e0a307/crypto/apple_keychain_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8468b4eb877dd991361f0da7541c7da961c8b3c7 commit 8468b4eb877dd991361f0da7541c7da961c8b3c7 Author: erikchen <erikchen@chromium.org> Date: Thu Mar 17 01:05:00 2016 Replace -[IOBluetoothL2CAPChannel getDevice] with -[IOBluetoothL2CAPChannel device]. The former method is deprecated, the latter is not. They have the same functionality. https://developer.apple.com/library/mac/releasenotes/General/MacOSXLionAPIDiffs/IOBluetooth.html BUG= 592663 Review URL: https://codereview.chromium.org/1813533002 Cr-Commit-Position: refs/heads/master@{#381618} [modify] https://crrev.com/8468b4eb877dd991361f0da7541c7da961c8b3c7/device/bluetooth/bluetooth_l2cap_channel_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2200abc5d620cc7495635767bf833aacd7af48f commit f2200abc5d620cc7495635767bf833aacd7af48f Author: erikchen <erikchen@chromium.org> Date: Tue Mar 22 23:02:59 2016 Update BookmarkBarController to use non-deprecated dragging APIs. This CL theoretically should not produce any behavior change. This CL replaces the method -[NSView dragImage:...] with -[NSView beginDraggingSessionWithItems:...]. There are three major differences. 1. The new API is asynchronous, whereas the old one ran a nested run loop. This CL runs a nested run loop to maintain the previous behavior. 2. The new API makes use of some new terminology and protocols (NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still the same. This CL renames some methods and variables. 3. The new API requires that custom PasteBoard types use reverse DNS notation. BUG= 592663 Review URL: https://codereview.chromium.org/1815053002 Cr-Commit-Position: refs/heads/master@{#382722} [modify] https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h [modify] https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm [modify] https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46cc2e824110f888200f0f16581e09199bc31a0e commit 46cc2e824110f888200f0f16581e09199bc31a0e Author: erikchen <erikchen@chromium.org> Date: Wed Mar 30 20:21:35 2016 gtm: Stop compiling two unused files. The files used methods deprecated in OS X 10.7. BUG= 592663 Review URL: https://codereview.chromium.org/1847653002 Cr-Commit-Position: refs/heads/master@{#384075} [modify] https://crrev.com/46cc2e824110f888200f0f16581e09199bc31a0e/third_party/google_toolbox_for_mac/BUILD.gn [modify] https://crrev.com/46cc2e824110f888200f0f16581e09199bc31a0e/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea4f3aa835f5de37682a3339fd51d8bbc428d373 commit ea4f3aa835f5de37682a3339fd51d8bbc428d373 Author: erikchen <erikchen@chromium.org> Date: Thu Mar 31 18:11:50 2016 Explicitly declare a method in WebContentsViewCocoa. The method -[NSObject draggingSourceOperationMaskForLocal:] is marked as deprecated, but the non-deprecated API -[NSWindow dragImage:...] still relies on it. Explicitly declaring the method in the public interface for WebContentsViewCocoa allows the method to be called from a test without warnings. BUG= 592663 Review URL: https://codereview.chromium.org/1850483002 Cr-Commit-Position: refs/heads/master@{#384330} [modify] https://crrev.com/ea4f3aa835f5de37682a3339fd51d8bbc428d373/content/browser/web_contents/web_contents_view_mac.h [modify] https://crrev.com/ea4f3aa835f5de37682a3339fd51d8bbc428d373/content/browser/web_contents/web_contents_view_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df2f225a8b0e9bb797a0a8667ea601ac67941e28 commit df2f225a8b0e9bb797a0a8667ea601ac67941e28 Author: erikchen <erikchen@chromium.org> Date: Sat Apr 02 00:03:45 2016 Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs. This CL theoretically should not produce any behavior change. This CL replaces the method -[NSView dragImage:...] with -[NSView beginDraggingSessionWithItems:...]. There are two major differences. 1. The new API is asynchronous, whereas the old one ran a nested run loop. This CL runs a nested run loop to maintain the previous behavior. 2. The new API makes use of some new terminology and protocols (NSDraggingSession) but the underlying logic is still the same. This CL also fixes some improper uses of NSPasteboard in clipboard_mac.mm. BUG= 592663 Review URL: https://codereview.chromium.org/1841813002 Cr-Commit-Position: refs/heads/master@{#384739} [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/ui/base/clipboard/clipboard_mac.mm [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/ui/base/clipboard/clipboard_util_mac.h [modify] https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28/ui/base/clipboard/clipboard_util_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f commit 4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f Author: erikchen <erikchen@chromium.org> Date: Mon Apr 04 21:05:04 2016 mac: Bump the deployment target to OS X 10.7. BUG= 592663 Review URL: https://codereview.chromium.org/1847533004 Cr-Commit-Position: refs/heads/master@{#385003} [modify] https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f/build/common.gypi [modify] https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f/build_overrides/build.gni
This is done. 10.8 next? :-) (I think we don't have a bug for 10.8 yet, only 10.9)
Actually, not done, see blockers.
Comment 1 by bugdroid1@chromium.org
, Mar 8 2016