on @media print, text-shadow: none on ::before and ::after pseudo-elements resets quotes
Reported by
chrishar...@gmail.com,
Mar 7 2016
|
|||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36
Steps to reproduce the problem:
1. Save the following HTML/CSS in an .html file:
<style>
.brackets { quotes: '[' ']'; }
.brackets::before {content: open-quote; }
.brackets::after {content: close-quote; }
</style>
<span class="brackets">any element</span>
2. View the page both normally and with the print emulator. Everything appears as expected.
3. Add the following CSS:
@media print {
*::before,
*::after { text-shadow: none; }
}
4. View the page without emulation. It works as expected.
5. Now view the page with print emulation. The left and right brackets have been replaced with left and right double-quotes.
6. In the Developer Tools Inspector, uncheck the `text-shadow: none;` property. The brackets return, replacing the quotation marks.
7. Remove the *::before selector in @media print, and reload the page (with print emulator). The ::before shows a left bracket as expected, but the ::after still shows a right double-quote. The same is true vice versa.
What is the expected behavior?
The left and right brackets should remain in place, even when viewing with the print emulator. The `text-shadow` property should not affect the `quotes` property.
What went wrong?
The computed values of `open-quote` and `close-quote` seem to have been reset.
Did this work before? N/A
Chrome version: 48.0.2564.116 Channel: stable
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 20.0 r0
,
Mar 7 2016
,
Mar 9 2017
,
Mar 9 2017
Able to repro on Linux stable and Mac canary.
,
Mar 14 2017
I tried r340000 as a random older build and it repros there too. Not sure if this ever worked before so we probably don't need to bisect?
,
Mar 17 2017
,
Mar 17 2017
Unable to reproduce the issue on Linux Ubuntu-14.04,Mac 10.12.3 using chrome stable version-57.0.2987.98 ,Canary-59.0.3043.0 & reported version-48.0.2564.116 as per comment#0. Could you please upgrade to the latest chrome stable version & check the issue.Please let us know your observations with screencast if still issue persists. Please find the attached screencast for reference & revert us if we miss any steps to reproduce the issue. Thans in advance.
,
Mar 25 2017
jmukthavaram@chromium.org, Thanks for your screencast, however in Step 3---"add the following CSS"---I clearly meant for you to add that code within the ‹style› element. Using Chrome 57.0.2987.110 (macOS Sierra 10.12.3), go here http://codepen.io/chharvey/pen/aJjbZm?editors=1100 and try it out.
,
Mar 28 2017
chrisharvey2pi@, Thanks for the reply. Able to reproduce the issue on Windows 7, Mac 10.12.3 & Ubuntu 14.04 using chrome reported version -48.0.2564.116 ,stable-57.0.2987.110 & Canary-59.0.3053.3 as per the comment#0 & comment#8.Observed that the the ' left and right brackets ' are changed to 'double quotes' when viewing with the print emulator. Issue observed from M48 as Devtools->moretools->rendering settings options are not available in the earlier builds of M48.Hence marking it as 'Untriaged' and confirming this issue to get more inputs from Dev team. Please find the attached screencast for reference. Thank you!!
,
Mar 29 2017
@media screen leads to the same problems. This isn't printing specific.
,
Mar 30 2017
,
Oct 31 2017
Can't seem to reproduce on 60.0.3112.113 with the link in #c8. Requesting reverse bisect to find the commit that fixed this.
,
Oct 31 2017
Able to reproduce the issue on windows 7,Mac 10.12.6 and Ubuntu 14.04 using Chrome earlier version of M60. But this is working as intended on stable(62.0.3202.75) and canary(64.0.3253.0). Seems the issue got fixed on later versions. Worked on reverse bisect and below is the info: Manual Bisect: ------------ First Good build:60.0.3102.0 - Revision-472262 Last Bad build:60.0.3101.0 - Revision-471958 Bisect Tool Info: (Reverse bisect)-old bisect script as new script is not working for the above range ---------------- You are probably looking for a change made after 472225 (known good), but no later than 472234 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/6e0f47b9cc33450f93d02d238cd4e60dffa89421..885a5dea20c9790ed62081a7909b8f675da54eac Possible suspect: ----------------- https://chromium.googlesource.com/chromium/src/+/885a5dea20c9790ed62081a7909b8f675da54eac shend@ Please take a look & reassign if this is not related to your change. Thanks..!
,
Oct 31 2017
Hmm I did not expect that. After some digging, it looks like we accidentally fixed the bug by generating ComputedStyle! The old copy constructor forgot to copy over quotes data, which would cause them to be "reset". nainar, I think this is the first bug that Clockwork (accidentally) fixed.
,
Nov 29 2017
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by alph@chromium.org
, Mar 7 2016Status: Untriaged (was: Unconfirmed)