New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592561 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
█ lgar...@chromium.org
eranm@chromium.org
asymmetric@chromium.org
rsleevi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rip out SignedCertificateTimestampStore (it's unused)

Project Member Reported by est...@chromium.org, Mar 7 2016 
The SignedCertificateTimestampStore is left over from the days when Chrome had an SCT viewer UI on some platforms, but SCTs are no longer ever retrieved from it and it just wastes memory.

It might makes sense to show SCT details in the DevTools security panel ( issue 591848 ), but for that we can probably just send the relevant details to DevTools along with requests, rather than storing the details in the browser process as long as the renderer process is alive.

Comment 1 by est...@chromium.org, Mar 7 2016 

Actually, on second thought, maybe it's not so simple to send the relevant details to DevTools, since we would only want to send them to the renderer if DevTools is enabled, not all the time. Hmm.

Comment 2 by daniel.w...@gmail.com, Mar 21 2016 

Please have a look at the following CL and its discussion: https://codereview.chromium.org/1772603002/

Comment 3 by daniel.w...@gmail.com, May 6 2016 

I have extracted the removal of the SignedCertificateTimestampStore from the previously mentioned CL into an own one: https://codereview.chromium.org/1957483003/
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f6c692a10e5da4d1d87dac49d243359048f097

commit 88f6c692a10e5da4d1d87dac49d243359048f097
Author: daniel.waxweiler <daniel.waxweiler@gmail.com>
Date: Tue May 17 23:53:33 2016

Removal of SignedCertificateTimestampStore

SignedCertificateTimestampStore, SignedCertificateTimestampIDStatusList and SignedCertificateTimestampIDStatus were removed because SCTs are never retrieved from the store (leftover of SCT viewer UI on some platforms). The SCTs are only shown in the DevTools, so they can be sent on IPCs if the DevTools is enabled to reduce memory usage. Numbers of invalid, valid and unknown SCTs were added to SSLStatus to access them quickly. To the ResourceResponseInfo was added a SignedCertificateTimestampAndStatusList attribute, to which a value is only assigned if the DevTools are enabled. I will also have a follow-up CL that displays SCT details in the DevTools.

BUG= 592561 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1957483003
Cr-Commit-Position: refs/heads/master@{#394271}

[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/AUTHORS
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/chrome/browser/ssl/chrome_security_state_model_client.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/chrome/browser/ui/website_settings/website_settings.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/browser/loader/resource_loader.h
[delete] https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3/content/browser/signed_certificate_timestamp_store_impl.cc
[delete] https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3/content/browser/signed_certificate_timestamp_store_impl.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/common/resource_messages.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/common/resource_messages.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/common/ssl_status_serialization.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/common/ssl_status_serialization_unittest.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/content_browser.gypi
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/content_common.gypi
[delete] https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3/content/public/browser/signed_certificate_timestamp_store.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/public/common/resource_response.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/public/common/resource_response_info.h
[delete] https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3/content/public/common/signed_certificate_timestamp_id_and_status.cc
[delete] https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3/content/public/common/signed_certificate_timestamp_id_and_status.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/public/common/ssl_status.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/content/public/common/ssl_status.h
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/net/ssl/signed_certificate_timestamp_and_status.cc
[modify] https://crrev.com/88f6c692a10e5da4d1d87dac49d243359048f097/net/ssl/signed_certificate_timestamp_and_status.h

Comment 5 by robpercival@chromium.org, Oct 3 2016

Status: Fixed (was: Available)
►

Sign in to add a comment