New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592437 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Flaky tests in OpenTabsTest: testUploadAndCloseOpenTab and testUploadMultipleOpenTabs

Project Member Reported by mvanouwe...@chromium.org, Mar 7 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71eeed137143e37de4957ece2e91d2881a2069fb

commit 71eeed137143e37de4957ece2e91d2881a2069fb
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Mon Mar 07 13:54:55 2016

Mark some OpenTabsTest tests as flaky.

BUG= 592437 
TBR=nyquist
NOTRY=true

Review URL: https://codereview.chromium.org/1772653002

Cr-Commit-Position: refs/heads/master@{#379551}

[modify] https://crrev.com/71eeed137143e37de4957ece2e91d2881a2069fb/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java

Owner: maxbogue@chromium.org
Labels: Sync-Code-Health
Components: Services>Sync
Labels: -Sync-Code-Health Hotlist-CodeHealth
Status: WontFix (was: Assigned)
Closing the flaky bugs assigned to me as WontFix as I am leaving Chrome. If these are still occurring please go through the sync triage process again.

Comment 7 by mkwst@chromium.org, Jun 29 2017

Owner: nyquist@chromium.org
Status: Assigned (was: WontFix)
`testUploadOpenTab` is starting to crash as well. Reopening, assigning back to nyquist@ for triage. (Hello, again! :) )
Cc: s...@chromium.org
Owner: zea@chromium.org
Reassigning to zea@ for triage. Adding skym@ to CC in case they want to take a peek.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d723c318c7dd338e17b8b0de08ac34086d0bdb88

commit d723c318c7dd338e17b8b0de08ac34086d0bdb88
Author: Mike West <mkwst@chromium.org>
Date: Thu Jun 29 11:28:03 2017

Sync tests crashing on Android.

- org.chromium.chrome.browser.sync.TypedUrlsTest#testUploadTypedUrl
- org.chromium.chrome.browser.sync.OpenTabsTest#testUploadOpenTab

Started in https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/43627.

Bug:  592437 
TBR: nyquist@chromium.org
Change-Id: I8b665e199283269f28aa6cfc40694a22c39aa94e
Reviewed-on: https://chromium-review.googlesource.com/554757
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483325}
[modify] https://crrev.com/d723c318c7dd338e17b8b0de08ac34086d0bdb88/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
[modify] https://crrev.com/d723c318c7dd338e17b8b0de08ac34086d0bdb88/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java

Comment 10 by zea@chromium.org, Jan 17 2018

Labels: SyncHandoff2018 Build-Tests
Owner: ----
Status: Available (was: Assigned)

Comment 11 by treib@chromium.org, Apr 30 2018

Cc: mamir@chromium.org mastiz@chromium.org nyquist@chromium.org jkrcal@chromium.org yfried...@chromium.org treib@chromium.org
Components: Tests>Flaky
Labels: Test-Disabled
Owner: mastiz@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3df24d27fb05805b8e15b8515bfbf12a9bd8c29c

commit 3df24d27fb05805b8e15b8515bfbf12a9bd8c29c
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Jun 26 10:07:17 2018

Remove FlakyTest annotation for OpenTabsTest and and related

The underlying implementations have changed substantially due to
migrations to USS, and we're not aware of the flakes still being an
issue.

Bug:  592437 
Change-Id: I0472379a3fa35742863f1c862d632dea902663d5
Reviewed-on: https://chromium-review.googlesource.com/1113184
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570362}
[modify] https://crrev.com/3df24d27fb05805b8e15b8515bfbf12a9bd8c29c/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
[modify] https://crrev.com/3df24d27fb05805b8e15b8515bfbf12a9bd8c29c/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment