Issue metadata
Sign in to add a comment
|
Regression: Unable to open the 'Task manager' window using 'Shift+Esc' key and unnecessary 'Cast' overlay is getting closed.
Reported by
dchau...@etouch.net,
Mar 7 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2670.0 (Official Build) 295ae19dead08c00aed4c7dd634b101551c14d10-refs/heads/master@{#379497} 32/64-bit. OS: Windows(Aero Enabled), Linux. Pre-condition: Enable the 'Media Router' flag from chrome://flags. What steps will reproduce the problem? 1. Launch chrome, go to wrench and click on 'Cast' option (Cast overlay will open). 2. Now, press 'Shift+Esc' key from keyboad to open task manager window and observe. Unable to open the 'Task manager' window and 'Cast' overlay is getting closed. Should be able to open the 'Task manager' window and 'Cast' overlay should not get closed. This is a regression issue broken in M-50 series, below is bisect info. Good build: 50.0.2651.0 Bad build: 50.0.2653.2 Narow bisect: https://chromium.googlesource.com/chromium/src/+log/6cb61123de1dfd590e9a3e646ab08e2cb7d37cd7..fcc56daa2d2ce3f9e900c13aa84e26d54ec50fff?pretty=fuller&n=50 Suspecting: r375626 Note: This issue is not seen on 'Mac' OS. Kindly review the attached screencast for reference.
,
Mar 7 2016
,
Mar 9 2016
,
Mar 15 2016
The task manager is opened on Mac via Cmd+Opt+Esc.
,
Mar 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b1b55fa2851c0dce144badc3e29c9b63e2fccd commit 96b1b55fa2851c0dce144badc3e29c9b63e2fccd Author: apacible <apacible@chromium.org> Date: Thu Mar 17 23:11:43 2016 [Media Router WebUI] Update ESC handling. ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts. BUG= 592422 Review URL: https://codereview.chromium.org/1800213002 Cr-Commit-Position: refs/heads/master@{#381827} [modify] https://crrev.com/96b1b55fa2851c0dce144badc3e29c9b63e2fccd/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/96b1b55fa2851c0dce144badc3e29c9b63e2fccd/chrome/browser/resources/media_router/media_router.js
,
Mar 18 2016
,
Mar 22 2016
Requesting merge to M50 to avoid skewing metrics.
,
Mar 22 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b21b6a1daece0824b474b3507ed17cba680509d commit 2b21b6a1daece0824b474b3507ed17cba680509d Author: Jennifer Apacible <apacible@google.com> Date: Tue Mar 22 15:49:15 2016 [Media Router WebUI] Update ESC handling. ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts. BUG= 592422 Review URL: https://codereview.chromium.org/1800213002 Cr-Commit-Position: refs/heads/master@{#381827} (cherry picked from commit 96b1b55fa2851c0dce144badc3e29c9b63e2fccd) Review URL: https://codereview.chromium.org/1824623004 . Cr-Commit-Position: refs/branch-heads/2661@{#343} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/2b21b6a1daece0824b474b3507ed17cba680509d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/2b21b6a1daece0824b474b3507ed17cba680509d/chrome/browser/resources/media_router/media_router.js
,
Mar 23 2016
Above issue is fixed on latest canary version i.e 51.0.2687.0 (Official Build) & latest beta i.e 50.0.2661.49 (Official Build) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 7 2016