New issue
Advanced search Search tips

Issue 592409 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue v8:4807
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Prepare layout tests for V8 change to variable declaration break locations

Project Member Reported by yangguo@chromium.org, Mar 7 2016

Issue description

Mergedinto: v8:4807
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1997c29e5846c79df3efd9f383ce340f03f8efb

commit d1997c29e5846c79df3efd9f383ce340f03f8efb
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Jun 17 20:36:34 2016

Change remaining NeedsManualRebaseline to Failure or Pass Failure

Some tests have been marked NeedsManualRebaseline for a long
time without being rebaselined.

Some tests can't be rebaselined because of flakiness.

BUG=487344, 620126 , 592409 , 603997 , 597221 , 569139 

Review-Url: https://codereview.chromium.org/2075993002
Cr-Commit-Position: refs/heads/master@{#400492}

[modify] https://crrev.com/d1997c29e5846c79df3efd9f383ce340f03f8efb/third_party/WebKit/LayoutTests/TestExpectations

Status: Assigned (was: Duplicate)
yangguo@ can you check if the tests need rebaseline or just fail?
@wangxiangzhu thanks for the reminder. This indeed needs to be rebaselined. Do you want me to submit a CL or would you like to do that yourself?
In fact, commit e23ec622747d4fc25e2989e36ef62709d9d707e6 both introduced the temporary test expectation in TestExpectations and updated the test to expect the new behavior. Removing the line in TestExpectations will do.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda3cf5e2c508786fa7cf1cfafaff443f9518bdd

commit cda3cf5e2c508786fa7cf1cfafaff443f9518bdd
Author: yangguo <yangguo@chromium.org>
Date: Mon Jun 20 09:00:17 2016

LayoutTests: remove outdated test expectation (introduced for V8 roll).

R=machenbach@chromium.org
BUG= 592409 

Review-Url: https://codereview.chromium.org/2084493002
Cr-Commit-Position: refs/heads/master@{#400637}

[modify] https://crrev.com/cda3cf5e2c508786fa7cf1cfafaff443f9518bdd/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment