Issue metadata
Sign in to add a comment
|
Prepare layout tests for V8 change to variable declaration break locations |
||||||||||||||||||||
Issue description
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e23ec622747d4fc25e2989e36ef62709d9d707e6 commit e23ec622747d4fc25e2989e36ef62709d9d707e6 Author: yangguo <yangguo@chromium.org> Date: Mon Mar 07 12:54:11 2016 LayoutTests: prepare for V8 changes wrt var declaration break locations. R=machenbach@chromium.org BUG= chromium:592409 Review URL: https://codereview.chromium.org/1774503003 Cr-Commit-Position: refs/heads/master@{#379542} [modify] https://crrev.com/e23ec622747d4fc25e2989e36ef62709d9d707e6/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e23ec622747d4fc25e2989e36ef62709d9d707e6/third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges-expected.txt
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1997c29e5846c79df3efd9f383ce340f03f8efb commit d1997c29e5846c79df3efd9f383ce340f03f8efb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Jun 17 20:36:34 2016 Change remaining NeedsManualRebaseline to Failure or Pass Failure Some tests have been marked NeedsManualRebaseline for a long time without being rebaselined. Some tests can't be rebaselined because of flakiness. BUG=487344, 620126 , 592409 , 603997 , 597221 , 569139 Review-Url: https://codereview.chromium.org/2075993002 Cr-Commit-Position: refs/heads/master@{#400492} [modify] https://crrev.com/d1997c29e5846c79df3efd9f383ce340f03f8efb/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 17 2016
yangguo@ can you check if the tests need rebaseline or just fail?
,
Jun 20 2016
@wangxiangzhu thanks for the reminder. This indeed needs to be rebaselined. Do you want me to submit a CL or would you like to do that yourself?
,
Jun 20 2016
In fact, commit e23ec622747d4fc25e2989e36ef62709d9d707e6 both introduced the temporary test expectation in TestExpectations and updated the test to expect the new behavior. Removing the line in TestExpectations will do.
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cda3cf5e2c508786fa7cf1cfafaff443f9518bdd commit cda3cf5e2c508786fa7cf1cfafaff443f9518bdd Author: yangguo <yangguo@chromium.org> Date: Mon Jun 20 09:00:17 2016 LayoutTests: remove outdated test expectation (introduced for V8 roll). R=machenbach@chromium.org BUG= 592409 Review-Url: https://codereview.chromium.org/2084493002 Cr-Commit-Position: refs/heads/master@{#400637} [modify] https://crrev.com/cda3cf5e2c508786fa7cf1cfafaff443f9518bdd/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 20 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by yangguo@chromium.org
, Mar 7 2016Status: Duplicate (was: Assigned)