New issue
Advanced search Search tips

Issue 592382 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Mar 2016
Cc:
engedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update password bubble shows Android hash

Project Member Reported by vasi...@chromium.org, Mar 7 2016 
Version: 51.0.2667.0
OS: all

What steps will reproduce the problem?
1. Save a password with an Android app.
2. Go to the site assosiated with the app.
3. Login with a new password.

What is the expected output? What do you see instead?
The update password bubble appears (correct) showing the Android hash (wrong).
Screen Shot 2016-03-02 at 9.55.36 PM.png
55.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b

commit 6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b
Author: vasilii <vasilii@chromium.org>
Date: Tue Mar 08 16:22:46 2016

Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long hash. This is a quick fix to be merged back to M50.

BUG= 592382 

Review URL: https://codereview.chromium.org/1771363002

Cr-Commit-Position: refs/heads/master@{#379838}

[modify] https://crrev.com/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

Comment 2 by vasi...@chromium.org, Mar 9 2016

Labels: Merge-Request-50 M-50
Status: Started (was: Assigned)
I want to merge r379838 to M50. It's a UI change only.

Comment 3 by tin...@google.com, Mar 9 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8e9e90380890bf334462610d0b0d4cb2d9b52c8

commit b8e9e90380890bf334462610d0b0d4cb2d9b52c8
Author: vasilii <vasilii@chromium.org>
Date: Wed Mar 09 18:42:40 2016

Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long hash. This is a quick fix to be merged back to M50.

BUG= 592382 
TBR=engedy@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1771363002

Cr-Commit-Position: refs/heads/master@{#379838}
(cherry picked from commit 6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b)

Review URL: https://codereview.chromium.org/1776883004

Cr-Commit-Position: refs/branch-heads/2661@{#145}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/b8e9e90380890bf334462610d0b0d4cb2d9b52c8/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/b8e9e90380890bf334462610d0b0d4cb2d9b52c8/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14

commit 5fe6793b2e0afeb3e395ea49dd346bf5747b0f14
Author: vasilii <vasilii@chromium.org>
Date: Thu Mar 10 15:41:01 2016

Fix the password bubble titles for android.

It should be "Do you want to save the password for <site>?" and "Saved passwords for <site>".

BUG= 592382 

Review URL: https://codereview.chromium.org/1776673003

Cr-Commit-Position: refs/heads/master@{#380413}

[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_state.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_state.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_test.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/chrome/browser/ui/passwords/passwords_model_delegate.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/components/password_manager/core/browser/credential_manager_pending_request_task.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Comment 6 by vasi...@chromium.org, Mar 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment