Wrong text is seen over tool bar on selecting folder in Files.app |
|||||||
Issue descriptionVersion: 50.0.2661.16 (Official Build) dev (64-bit) OS: Chrome Platform: 7978.7.0 (Official Build) dev-channel Peppy, Daisy, Blaze, Quawks What steps will reproduce the problem? 1.Sign in to user>> go to files app>> create one folder>> and observe the menu bar on the top Expected: On selecting the folder it should show 1 folder selected or new folder is selected (Please observe below in the screenshot) Actual: Instead 1 folders selected is seen (Refer screenshot) This is a Regression issue as it is working fine in M38: 38.0.2125.44/6158.19.0 beta-channel daisy, Note: Issue is seen in M48: 48.0.2564.116/7647.84.0 stable-channel daisy as well
,
Apr 14 2016
Yes, we should not use plural when only one folder/file is selected. oka@, could you take a look?
,
Apr 14 2016
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f670eeb7656e38a0953bd971c612c7fe407fe039 commit f670eeb7656e38a0953bd971c612c7fe407fe039 Author: oka <oka@chromium.org> Date: Thu Apr 14 08:56:38 2016 Use singular when only one item is selected. BUG= 592372 TEST=manually Review URL: https://codereview.chromium.org/1890783002 Cr-Commit-Position: refs/heads/master@{#387266} [modify] https://crrev.com/f670eeb7656e38a0953bd971c612c7fe407fe039/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/f670eeb7656e38a0953bd971c612c7fe407fe039/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/f670eeb7656e38a0953bd971c612c7fe407fe039/ui/file_manager/file_manager/foreground/js/toolbar_controller.js
,
Apr 14 2016
,
Apr 25 2016
Now the string says "1 directory selected". Shouldn't it be "1 folder selected", in uniformity with the plural "x folders selected" ? Marking Assigned. Please mark it Fixed if the change is intentional.
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e33dc248e442cebbe610f1f8abb2c2e246b0b09e commit e33dc248e442cebbe610f1f8abb2c2e246b0b09e Author: oka <oka@chromium.org> Date: Fri May 06 06:38:15 2016 s/directory/folder/ to match it with the plural case. BUG= 592372 TEST=manually Review-Url: https://codereview.chromium.org/1954993002 Cr-Commit-Position: refs/heads/master@{#392016} [modify] https://crrev.com/e33dc248e442cebbe610f1f8abb2c2e246b0b09e/chrome/app/chromeos_strings.grdp
,
May 6 2016
Fixed. Thanks.
,
May 13 2016
Thanks!! Verified on ChromeOS (8314.0.0, 52.0.2733.0) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kavvaru@chromium.org
, Mar 7 2016