New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592371 link

Starred by 1 user
Status: Assigned
Owner:
hayato@chromium.org
Cc:
█ kochi@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Separate Shadow DOM v1 layout tests from fast/dom/shadow

Project Member Reported by kochi@chromium.org, Mar 7 2016 
Historically Shadow DOM layout tests are placed in
LayoutTests/fast/dom/shadow/*, but it makes sense to
have a separate directory for v1-only tests.

How about fast/shadowdom/*?

For v0/v1 mix tests, I'd think they would better fit in the
old directory, because once v0 deprecation is complete,
they can be removed altogether.

Comment 1 by hayato@chromium.org, Mar 8 2016

Cc: kochi@chromium.org
Owner: yuzus@chromium.org
I prefer fast/shadow-dom.

Comment 2 by hayato@chromium.org, Mar 8 2016 

I chatted with tkent@. It looks okay to use LayoutTests/shadow-dom.

Comment 3 by kochi@chromium.org, Mar 8 2016 

Maybe v0/v1 mix tests uses v1 API anyway, it should be in //shadow-dom.

First move CL created:
https://codereview.chromium.org/1774113002/

We should also move tests that are still relevant for v1.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60a57eb9787d57e1a31c452486c61fec0e3c598d

commit 60a57eb9787d57e1a31c452486c61fec0e3c598d
Author: kochi <kochi@chromium.org>
Date: Wed Mar 09 04:50:07 2016

Move Shadow DOM V1 tests from fast/dom/shadow to shadow-dom

Move apparent users of Shadow DOM V1 API from
fast/dom/shadow to top-level shadow-dom.
This only moves these files and adjust relative include paths.

BUG=592371

Review URL: https://codereview.chromium.org/1774113002

Cr-Commit-Position: refs/heads/master@{#380069}

[delete] https://crrev.com/3754aa680c145bbf5211b7604406ebf2d7d627e2/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinator-and-shadow-pseudo.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinators-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinators.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host2-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host3-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host3.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host5-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host5.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/delegatesFocus-highlight-sibling-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/delegatesFocus-highlight-sibling.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path-empty.html
[add] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot2-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/event-path-with-slot.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-method-with-delegatesFocus-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-method-with-delegatesFocus.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-with-delegatesFocus-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-with-delegatesFocus.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-shadowhost-display-none-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-shadowhost-display-none.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-slide-on-shadow-host-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-slide-on-shadow-host.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-with-dom-mutation-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/focus-with-dom-mutation.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/labelsnodelist-in-shadow.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/multiple-shadowroot-with-params-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/multiple-shadowroot-with-params.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/radionodelist-in-shadow.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/scoped-events-by-ua-stopped.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotchange-event.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-css-text.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-dynamic-attribute-change-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-dynamic-attribute-change.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash-expected.txt
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-shared-style-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-shared-style.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/tabindex-slot.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/treeRoot.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v0-inert-features-in-v1-shadow-trees.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-attachShadow-safelist.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-default-slots.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-1-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-1.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-2-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-1.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-dynamic.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-in-v0.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-with-closed-shadow-tree.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dom-mutation.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dynamic-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dynamic.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-1-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-1.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-2-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-3-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-3.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-1.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-2.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-3.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-4.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-document-tree.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-v0-expected.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-v0.html
[rename] https://crrev.com/60a57eb9787d57e1a31c452486c61fec0e3c598d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-text-nodes.html
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e8e902064db5a974e0f2af8c10703b7ccf98b6

commit b7e8e902064db5a974e0f2af8c10703b7ccf98b6
Author: kochi <kochi@chromium.org>
Date: Wed Mar 09 07:49:18 2016

Use Shadow DOM v1 APIs for Shadow DOM v1 tests

Use Shadow DOM v1 APIs where possible for layout tests in //shadow-dom
directory, e.g. Event.path -> Event.deepPath(), createShadowRoot({mode: 'open'})
-> attachShadow({mode: 'open'}).

BUG=592371

Review URL: https://codereview.chromium.org/1777833002

Cr-Commit-Position: refs/heads/master@{#380097}

[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter-expected.txt
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2-expected.txt
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2.html
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution.html
[modify] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points.html
[rename] https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6/third_party/WebKit/LayoutTests/shadow-dom/node-rootNode.html

Comment 6 by hayato@chromium.org, Jun 29 2016

Owner: hayato@chromium.org

Comment 7 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>DOM>ShadowDOM
►

Sign in to add a comment