New issue
Advanced search Search tips

Issue 592364 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Mar 2016
Cc:
kojii@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

CharacterData.h changes do no trigger relinking binary with GYP

Project Member Reported by drott@chromium.org, Mar 7 2016 
When touching CharacterData.h, in the GYP process this does not lead to updating the out/(Release|Debug)/gen/platform/CharacterData.cpp and in turn does not lead to an updated binary. Only changes to CharacterDataGenerator.cpp do so.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cf618b62ddd0efab7da0449c67b64a67d3bc397

commit 7cf618b62ddd0efab7da0449c67b64a67d3bc397
Author: drott <drott@chromium.org>
Date: Mon Mar 07 16:36:56 2016

Add CharacterData.h to input for Character Data generation step

Without this line, touching CharacterData.h does not trigger
regenerating the serialized character data tables.

R=kojii,dpranke
BUG= 592364 

Review URL: https://codereview.chromium.org/1768083002

Cr-Commit-Position: refs/heads/master@{#379561}

[modify] https://crrev.com/7cf618b62ddd0efab7da0449c67b64a67d3bc397/third_party/WebKit/Source/platform/platform_generated.gyp

Comment 2 by drott@chromium.org, Mar 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment