Regression: Translation issue is observed for "uol.com.br".
Reported by
jshan...@etouch.net,
Mar 7 2016
|
|||||
Issue descriptionChrome Version: 51.0.2670.0 (Official Build) 295ae19dead08c00aed4c7dd634b101551c14d10-refs/heads/master@{#379497}-32/64 bit OS: All(Win 7-Aero enabled) URL: http://www.uol.com.br/ Steps: 1. Launch Chrome and navigate to above URL. 2. Right click on page and observe. Actual: After step 1, 'Translate bubble' does not appear After step 2, 'Translate to English' option is disabled in context menu. Expected: After step 1, 'Translate bubble' should appear After step 2, 'Translate to English' option should not be disabled in context menu. This is a regression issue broken in M-50, below is bisect info. Good build: 50.0.2638.0 Bad build: 50.0.2639.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/de07d5638897139acffc67cdb4142cee4f912e3a..12b409a32f2498182e12dca4f32f91f04af7535d?pretty=fuller&n=100 Suspecting: r372891 ? Please help to re-assign if your change is not the cause for this issue.
,
Mar 7 2016
Looks like Translate component is enough.
,
Mar 7 2016
Will look.
,
Mar 8 2016
The cause of this is the auto-refresh meta tag on the page. I need to make the the translate machinery a bit smarter: instead of just never showing a bubble on pages with pending navigations/refreshes, we need to only ignore pages with reasonably fast refresh times (maybe < 10s?).
,
Mar 8 2016
Patch out for review https://codereview.chromium.org/1774663002.
,
Mar 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09edaa833dbbbba00648dadbb559d2b575be67bf commit 09edaa833dbbbba00648dadbb559d2b575be67bf Author: dglazkov <dglazkov@chromium.org> Date: Tue Mar 08 19:27:01 2016 Teach CRFO:CapturePageText to recognize page refreshes with long delays. In some cases, news sites put longish delays (over 1s) on their refresh meta tags, in order to update the page periodically. We should recognize this and not bail (as we used to) on page text capture on these types of pages -- so that the translate bubble/bar shows up. BUG= 592360 R=esprehn,jochen Review URL: https://codereview.chromium.org/1774663002 Cr-Commit-Position: refs/heads/master@{#379884} [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/chrome/browser/translate/translate_browsertest.cc [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/chrome/renderer/chrome_render_frame_observer.cc [add] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/chrome/test/data/translate/refresh_meta_tag_long.html [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/third_party/WebKit/Source/core/loader/NavigationScheduler.h [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/09edaa833dbbbba00648dadbb559d2b575be67bf/third_party/WebKit/public/web/WebLocalFrame.h
,
Mar 9 2016
,
Apr 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Mar 7 2016