Regression: Background grey highlight is not seen for extension icon while pressing down arrow key on context menu..
Reported by
rk...@etouch.net,
Mar 7 2016
|
||||||
Issue descriptionChrome Version: 51.0.2670.0 Revision 295ae19dead08c00aed4c7dd634b101551c14d10-refs/heads/master@{#379497}(32/64 bit) OS: Windows(Win-7 Aero Enabled), Linux Precondition : Enable "extension toolbar redesign" flag from chrome flags to view the Extension toolbar in wrench menu. URL: https://chrome.google.com/webstore/detail/save-to-pocket/niloccemoadcdkdjlinkgdfekeahmflj?hl=en What steps will reproduce the problem? 1. Launch chrome,navigate to above url and click on 'ADD TO Chrome' 2. Right click on extension icon and select 'Hide in chrome menu' option. 3. Click on wrench menu,right click on extension icon then press down arrow key and observe the highlight on extension icon. Background grey highlight is not seen for extension icon after pressing down arrow key on context menu. Background grey highlight for extension icon should be seen after pressing down arrow key on context menu. This is a regression issue,broken in 'M-51', below is bisect info: Good Build: 51.0.2663.0 Bad Build: 51.0.2664.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/42e463ac3a6f667821a8bed78ba0eafde79a7bfc..9b13cbdc3205421a28bd583878c1108ed0eaead0?pretty=fuller&n=100 Suspecting: r378300 Note: Issue is not seen on Mac OS.
,
Mar 7 2016
,
Mar 8 2016
Draft CL at https://codereview.chromium.org/1775533002/.
,
Mar 8 2016
,
Mar 23 2016
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34943cb4f328c269cb53091c0702c5380a675407 commit 34943cb4f328c269cb53091c0702c5380a675407 Author: varkha <varkha@chromium.org> Date: Thu Mar 24 20:14:25 2016 Fixes incorrect clearing of hot-tracked state when context menu is opened from a menu item Broken with the last change here: https://codereview.chromium.org/1741093002 Since menus can be nested using the same MenuController I think it would be correct to move |hot_button_| and its accessors into MenuItemView. This way there can be multiple views in hot-tracked state in the same MenuController as long as only one hot-tracked view is in any given menu item. BUG= 592359 Review URL: https://codereview.chromium.org/1775533002 Cr-Commit-Position: refs/heads/master@{#383128} [modify] https://crrev.com/34943cb4f328c269cb53091c0702c5380a675407/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/34943cb4f328c269cb53091c0702c5380a675407/ui/views/controls/menu/menu_controller.h [modify] https://crrev.com/34943cb4f328c269cb53091c0702c5380a675407/ui/views/controls/menu/menu_controller_unittest.cc
,
Mar 25 2016
,
May 19 2016
Verified on build 8172.39.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ranjitkan@chromium.org
, Mar 7 2016