Animation effect of Overwrite check box is seen not proper in Gallery.app |
||||||||||||||
Issue descriptionVersion: 50.0.2661.16 (Official Build) dev (64-bit) OS: Chrome Platform: 7978.7.0 (Official Build) dev-channel Peppy, Daisy, Blaze, Quawks What steps will reproduce the problem? 1.Sign in to user>> try to download 2,3 images>> open it in gallery 2.Go to edit settings>> Click on Overwrite original check box>> and observe Expected: The animation bubble should be seen proper on clicking Overwrite check box Actual: Instead it is seen not proper (Refer Screen cast) This is a Non-Regression issue as this a new feature introduced since M46: 46.0.2490.42/7390.37.0 beta channel Daisy Issue is not applicable to Linux and Windows
,
Mar 7 2016
@yawano: Yes, that ripple is doesn't start from the point where the user has to click and also we can see there are 2 ripples is showing on clicking.
,
Mar 7 2016
Thank you for the feedback. For 1: the ripple doesn't start from the point where the user has clicked, I think this is working as intended. We use paper-checkbox for it, and it works as it is now. - https://elements.polymer-project.org/elements/paper-checkbox?view=demo:demo/index.html&active=paper-checkbox For 2: two ripples can be seen, which click do you mean in the attached video? First/Second Activate/Deactivate click?
,
Mar 7 2016
Yes, it can be seen on doing all the operations (First/Second Activate/Deactivate click) as it is showing in the attached video.
,
Mar 7 2016
Could you describe about where two ripples can be seen in more details? I can only see one ripple in the attached movie.
,
Mar 7 2016
Please keep on clicking the Overwrite check box and observe it closely, then you can see the 3/4th part of the second ripple behind the full (first) ripple on clicking.
,
Apr 21 2016
On mousedown, I see a ripple whose center is the center of icon. On mouseup, I see a ripple whose center is the clicked point. yawano@, could you confirm? Please feel free to assign this to oka@. Thanks!
,
Apr 25 2016
Confirmed. This must be caused by the following CSS, I'll remove it. https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/gallery/css/gallery.css&l=545
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1eb08a0f5542836bc44930635d39ac4eef960a7 commit b1eb08a0f5542836bc44930635d39ac4eef960a7 Author: yawano <yawano@chromium.org> Date: Wed Apr 27 13:20:57 2016 Gallery: fix ripple animation of overwrite original checkbox BUG= 592324 TEST=manually tested as described in the issue Review URL: https://codereview.chromium.org/1919173006 Cr-Commit-Position: refs/heads/master@{#390058} [modify] https://crrev.com/b1eb08a0f5542836bc44930635d39ac4eef960a7/ui/file_manager/gallery/css/gallery.css [modify] https://crrev.com/b1eb08a0f5542836bc44930635d39ac4eef960a7/ui/file_manager/gallery/gallery.html
,
Apr 28 2016
,
May 6 2016
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by yawano@chromium.org
, Mar 7 2016