Crash in blink::Document::setTitleElement |
||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6408005303664640 Fuzzer: inferno_twister Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: UNKNOWN Crash Address: 0x000000000010 Crash State: blink::Document::setTitleElement blink::HTMLTitleElement::insertedInto blink::ContainerNode::notifyNodeInsertedInternal Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=379046:379326 Minimized Testcase (2.80 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94lXUqk2G_OKiaY64MH5aThre-s0K-UYLPUT3S4xqXjQIDFiM8s5ijEzrN_R4mQ0TKgKMJhC43iiqsCgs35Kq3meUGOcOVYRbnB3y2BVBQPhu3mDgvIOeTTM0QYb-9Sd8NwQmdS0Y3XJbru-z-0SoIu2vIMEA Filer: nyerramilli See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Mar 7 2016
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25217584cf92b17941a2db757baa2efd93a77d8 commit b25217584cf92b17941a2db757baa2efd93a77d8 Author: hyunjune.kim <hyunjune.kim@samsung.com> Date: Mon Mar 07 12:38:40 2016 Revert of Fix SVGDocument return title that is not a child of the root element (patchset #12 id:220001 of https://codereview.chromium.org/1752713002/ ) Reason for revert: Crash in blink:Document::setTitleElement. Issue : https://bugs.chromium.org/p/chromium/issues/detail?id=592323 Original issue's description: > Fix SVGDocument return title that is not a child of the root element > > The title element should be a child of the root element. > But currently return invalid title that is not a child of the root element. > > Because on getting, if the root element is an svg element in the SVG > namespace, then let value ba a concatenation of the data of all > the child Text nodes of the first title element in the SVG namespace > that is a child of the root element.[1] > > And on setting, let element be the first title element in the SVG > namespace that is a child of the root element, if any. > If there isn't one, create a title element in the SVG namespace, > insert it as the first child of the root element, and let element > be that element.[1] > > [1] https://html.spec.whatwg.org/multipage/dom.html#document.title > > BUG= 543061 > > Committed: https://crrev.com/2764e5d8a0ec6cf13cb4d918a5032e45da691247 > Cr-Commit-Position: refs/heads/master@{#379301} TBR=fs@opera.com,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 54306 , 592323 Review URL: https://codereview.chromium.org/1771703003 Cr-Commit-Position: refs/heads/master@{#379541} [add] https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt [delete] https://crrev.com/d65f3cc4524525f69e30ce6e6c71769ee44459ba/third_party/WebKit/LayoutTests/svg/dom/svg-document-set-title-mutations.html [modify] https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp [modify] https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8/third_party/WebKit/Source/core/svg/SVGTitleElement.h
,
Mar 7 2016
,
Mar 8 2016
ClusterFuzz has detected this issue as fixed in range 379540:379555. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6408005303664640 Fuzzer: inferno_twister Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: UNKNOWN Crash Address: 0x000000000010 Crash State: blink::Document::setTitleElement blink::HTMLTitleElement::insertedInto blink::ContainerNode::notifyNodeInsertedInternal Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=379046:379326 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=379540:379555 Minimized Testcase (2.80 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94lXUqk2G_OKiaY64MH5aThre-s0K-UYLPUT3S4xqXjQIDFiM8s5ijEzrN_R4mQ0TKgKMJhC43iiqsCgs35Kq3meUGOcOVYRbnB3y2BVBQPhu3mDgvIOeTTM0QYb-9Sd8NwQmdS0Y3XJbru-z-0SoIu2vIMEA See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Mar 8 2016
Issue 592833 has been merged into this issue.
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/962d172872d7097c7074c6597fd52732882a1d9f commit 962d172872d7097c7074c6597fd52732882a1d9f Author: hyunjune.kim <hyunjune.kim@samsung.com> Date: Fri Mar 11 14:58:20 2016 Fix SVGDocument return title that is not a child of the root element The title element should be a child of the root element. But currently return invalid title that is not a child of the root element. Because on getting, if the root element is an svg element in the SVG namespace, then let value ba a concatenation of the data of all the child Text nodes of the first title element in the SVG namespace that is a child of the root element.[1] And on setting, let element be the first title element in the SVG namespace that is a child of the root element, if any. If there isn't one, create a title element in the SVG namespace, insert it as the first child of the root element, and let element be that element.[1] About a patch reverted[2][3], didn't consider inner svg document in <html> or etc but is not <svg>. If be inner svg document and insert <title> element that is not svg namespace two times, occurred to crash. Because call the member function of instance(m_titleElement) that is null. And added crash case that is set-title-element-on-inner-svg-document.html. [1] https://html.spec.whatwg.org/multipage/dom.html#document.title [2] https://codereview.chromium.org/1771703003/ [3] https://codereview.chromium.org/1752713002/ BUG= 543061 , 592323 Review URL: https://codereview.chromium.org/1774913003 Cr-Commit-Position: refs/heads/master@{#380634} [delete] https://crrev.com/46bf9ff55e29336f3a26f2d3bee81b71a97de669/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt [add] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/LayoutTests/svg/dom/set-title-element-on-inner-svg-document.html [add] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/LayoutTests/svg/dom/set-title-html-namespace-on-SVG.html [add] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/LayoutTests/svg/dom/svg-document-set-title-mutations.html [modify] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp [modify] https://crrev.com/962d172872d7097c7074c6597fd52732882a1d9f/third_party/WebKit/Source/core/svg/SVGTitleElement.h
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by nyerramilli@chromium.org
, Mar 7 2016Labels: findit-for-crash Te-Logged
Owner: hyunjune...@samsung.com
Status: Assigned (was: Available)