SitePerProcessBrowserTest.SubframeGestureEventRouting failing under DrMemory and TSan |
||||||
Issue descriptionThis started in this build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%29/builds/6815 Sample output: SitePerProcessBrowserTest.SubframeGestureEventRouting: c:\b\build\slave\drm-cr\build\src\content\browser\site_per_process_browsertest.cc(4656): error: Value of: result Actual: "0 clicks received" Expected: "1 click received" It isn't clear why it started failing.
,
Mar 11 2016
This test also appears to be flaky under TSan on Linux: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/18004
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a87c5bb23137ad66a2dce5bfb2247b6ea8a25cf8 commit a87c5bb23137ad66a2dce5bfb2247b6ea8a25cf8 Author: reillyg <reillyg@chromium.org> Date: Fri Mar 11 19:25:58 2016 Disable SitePerProcessBrowserTest.SubframeGestureEventRouting under TSan. This test appears to be flaky in the same way it is under Dr. Memory which makes me think that there is a timing issue exposed by it running more slowly. BUG=592320 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1786743003 Cr-Commit-Position: refs/heads/master@{#380695} [modify] https://crrev.com/a87c5bb23137ad66a2dce5bfb2247b6ea8a25cf8/content/browser/site_per_process_browsertest.cc
,
Mar 11 2016
,
Jun 26 2017
More than just TSAN, this test has been flaky under Linux test bot: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_content_browsertests&tests=SitePerProcessBrowserTest.SubframeGestureEventRouting
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db3cdf7b22185905851f819c7c16b981961e5d4 commit 5db3cdf7b22185905851f819c7c16b981961e5d4 Author: Xida Chen <xidachen@chromium.org> Date: Mon Jun 26 15:32:44 2017 Disable flaky test SitePerProcessBrowserTest.SubframeGestureEventRouting on Linux TBR=wjmaclean@chromium.org NOTRY=true Bug: 592320 Change-Id: I7a26e3fd34e7fbb3511ddf178d1320cf33e9e65e Reviewed-on: https://chromium-review.googlesource.com/548895 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#482282} [modify] https://crrev.com/5db3cdf7b22185905851f819c7c16b981961e5d4/content/browser/site_per_process_browsertest.cc
,
Jul 6 2017
Issue 730650 has been merged into this issue.
,
Jul 6 2017
,
Jul 6 2017
Taking a look at this, my guess would be that it is a race: the SyntheticGesture mechanism marks a Gesture as 'FINISHED' when it is ready to send it, not when it has received an Ack from the renderer saying the event has done a roundtrip. This test should be converted to wait for an Ack instead of exiting the MessageLoop based on the SyntheticGesture OnComplete callback.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/257cb99d4c311481fcea083b95cd188fd0270b21 commit 257cb99d4c311481fcea083b95cd188fd0270b21 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Jul 06 15:34:11 2017 content: disable flaky SitePerProcessBrowserTest.SubframeGestureEventRouting This test has occasionally flaked on many platforms. BUG=592320, 730650 TBR=jam@chromium.org Change-Id: I20083d489dea70afbefea5b5b01249f346dce0b2 Reviewed-on: https://chromium-review.googlesource.com/561658 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#484605} [modify] https://crrev.com/257cb99d4c311481fcea083b95cd188fd0270b21/content/browser/site_per_process_browsertest.cc
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76701c26ccad0701a1f6c4e493c03e2203fd0190 commit 76701c26ccad0701a1f6c4e493c03e2203fd0190 Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed Sep 12 15:50:17 2018 Use ack-waiter to fix flake in SitePerProcessHitTestBrowserTest.SubframeGestureEventRouting. This test previously used the OnSyntheticGestureCompleted callback for synchronization, but that's wrong since it gets called once the event is sent to the renderer and not when the ack is received back. For this test we need the latter. Bug: 592320 Change-Id: I99cbf4343d4572a91f3c23ff4d4a414f49d4c622 Reviewed-on: https://chromium-review.googlesource.com/1219767 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#590698} [modify] https://crrev.com/76701c26ccad0701a1f6c4e493c03e2203fd0190/content/browser/site_per_process_hit_test_browsertest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2016