New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix app test shutdown flakiness

Project Member Reported by roc...@chromium.org, Mar 7 2016

Issue description

Many apptests appear to be flaky for the same reason: shutdown races.

In particular all the tests appear to run to completion just fine, but child processes may kill themselves prematurely and this can be interpreted as a failure.

WindowServerTest.ActivationNext in particular is failing much more often than the others since r379508 landed, enough that the bot often goes red for a cycle or two at a time.

I've done enough investigation to be convinced that the bindings patch isn't breaking this but only exposing symptoms of the problem for frequently -- maybe it's causing the shell connection to be terminated earlier with respect to other pipes and that leads to more frequent shutdown flake. The test always runs to completion, it just kills itself before signalling success.

Rather than needlessly revert the bindings patch again, I'm disabling this test to make the bot green while I investigate a proper solution to the flakiness.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e24568637dacaf449988cc4479813a99de58ea06

commit e24568637dacaf449988cc4479813a99de58ea06
Author: rockot <rockot@chromium.org>
Date: Mon Mar 07 06:17:42 2016

[mus] Disable badly flaking apptest

See the bug for details. The test itself is fine, but problems
with the apptest framework are for whatever reason exaggerated
when running this test.

BUG= 592313 
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1770753002

Cr-Commit-Position: refs/heads/master@{#379514}

[modify] https://crrev.com/e24568637dacaf449988cc4479813a99de58ea06/components/mus/ws/window_manager_client_apptest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65

commit 6a2b04272ba5fd3dad9c62f03144bad04e6cfa65
Author: rockot <rockot@chromium.org>
Date: Wed Mar 09 17:14:59 2016

Convert mus apptests to shelltests

This reworks some shelltest boilerplate to be more easily
consumable and converts all mus apptests to shelltests.

BUG= 592313 

Review URL: https://codereview.chromium.org/1771393002

Cr-Commit-Position: refs/heads/master@{#380148}

[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/BUILD.gn
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/public/cpp/tests/BUILD.gn
[add] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/public/cpp/tests/window_server_shelltest_base.cc
[add] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/public/cpp/tests/window_server_shelltest_base.h
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/public/cpp/tests/window_server_test_base.cc
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/public/cpp/tests/window_server_test_base.h
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/ws/BUILD.gn
[delete] https://crrev.com/16c219769022556b8bd29d917a93f8a7dbc5b900/components/mus/ws/apptest_manifest.json
[add] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/ws/mus_ws_unittests_app_manifest.json
[rename] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/ws/window_manager_client_unittest.cc
[rename] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/components/mus/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/mash/wm/BUILD.gn
[add] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/mojo/shell/public/cpp/test/BUILD.gn
[rename] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/mojo/shell/public/cpp/test/run_all_shelltests.cc
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/mojo/shell/tests/BUILD.gn
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/mojo/tools/data/apptests
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/testing/buildbot/chromium.win.json
[modify] https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65/testing/buildbot/gn_isolate_map.pyl

Status: Fixed (was: Assigned)
The test I filed this for has been fixed and re-enabled, so I'm closing. Rather than fixing apptests it looks like the path forward is to convert them all to shell tests.

Sign in to add a comment