New issue
Advanced search Search tips

Issue 592310 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.1% regression in webrtc.datachannel at 379275:379285

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592310

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAv8_uvwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 16 2016

Cc: yukishiino@chromium.org
Owner: yukishiino@chromium.org

=== Auto-CCing suspected CL author yukishiino@chromium.org ===

Hi yukishiino@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : bindings: Makes not call installDOMClassTemplate twice for the same interface.
Author  : yukishiino
Commit description:
  
If the interface implements partial interfaces, the current implementation
is calling V8DOMConfiguration::installDOMClassTemplate() twice (once for
core/ and the other for modules/).  This implementation is not intuitive,
and we cannot do only-once-things in installDOMClassTemplate().
For example, we cannot call V8DOMConfiguration::setClassString() in
installDOMClassTemplate().

This CL fixes so that we call initializeDOMInterfaceTemplate(), which is
renamed from installDOMClassTemplate(), only once for each interface.

Also separates each section/block with adding empty lines in both of
the template file and generated files.

BUG=

Review URL: https://codereview.chromium.org/1758113003

Cr-Commit-Position: refs/heads/master@{#379278}
Commit  : 3ee990d9bbf799ee4a81f843e6b1ab71d61883ba
Date    : Fri Mar 04 13:36:18 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379271         174607.0    4046.907108 8           good
chromium@379275         172466.5    3325.765003 8           good
chromium@379277         172970.5    5019.242942 8           good
chromium@379278         191274.4    6439.205293 5           bad
chromium@379285         189549.5    8350.907684 8           bad
chromium@379305         191616.0    5418.294513 8           bad

Bisect job ran on: winx64_10_perf_bisect
Bug ID: 592310

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests webrtc.datachannel
Test Metric: vm_working_set_final_size_total/vm_working_set_final_size_total
Relative Change: 11.71%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/467
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018075733957300928


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Cc: nyerramilli@chromium.org
Labels: TE-Triaged
based on bisect results in C#2, yukishiino@, could you please check the issue.
Ping yukishiino@
Status: Started (was: Assigned)
Cc: haraken@chromium.org
Status: WontFix (was: Started)
I made a fix at https://codereview.chromium.org/1828543008/ , but I made a decision not to land the CL because
1) CL makes the code a little hard to read, and
2) the metrics are considered not so serious.

Let me close this issue as WontFix.

Sign in to add a comment