New issue
Advanced search Search tips

Issue 592308 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 592077
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8% regression in webrtc.getusermedia at 379108:379137

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592308

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAv5jsuQoM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Mergedinto: 592077
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379107         8945.6      24.754798   5           good
chromium@379109         8948.8      51.722336   5           good
chromium@379110         8954.666667 95.955545   6           good
chromium@379111         9637.0      65.268675   4           bad
chromium@379114         9478.4      119.284534  5           bad
chromium@379121         9540.8      79.719508   5           bad
chromium@379135         9518.4      123.664061  5           bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 592308

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia
Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer
Relative Change: 6.40%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/2833
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018876785165108432


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379107         12552.0     54.510812   8           good
chromium@379109         12533.0     75.585335   8           good
chromium@379110         12514.5     59.404185   8           good
chromium@379111         13041.0     354.431537  8           bad
chromium@379115         13164.8     90.836116   5           bad
chromium@379122         13234.4     73.353936   5           bad
chromium@379137         13420.0     581.989691  5           bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 592308

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia
Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer
Relative Change: 6.83%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/504
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018876811741438048


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment