Issue metadata
Sign in to add a comment
|
8.5% regression in dromaeo.domcoretraverse at 379306:379321 |
||||||||||||||||||||
Issue descriptionChromiumPerf/win-zenbook/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-win7-x64-dual/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-win7-gpu-intel/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-win7-gpu-nvidia/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-win7-gpu-ati/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-win10/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-mac10/dromaeo.domcoretraverse / dom ChromiumPerf/chromium-rel-mac-hdd/dromaeo.domcoretraverse / dom
,
Mar 7 2016
=== Auto-CCing suspected CL author verwaest@chromium.org === Hi verwaest@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland "Speed up the LookupIterator" Author : verwaest Commit description: BUG= Review URL: https://codereview.chromium.org/1765713003 Cr-Commit-Position: refs/heads/master@{#34492} Commit : 683223b4ba4857f4b3c44afffc3939e1dd22269d Date : Fri Mar 04 11:53:24 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@379305 268.696951 2.660116 8 good chromium@379307 266.645237 1.468554 8 good chromium@379308 266.523498 2.725476 7 good chromium@379308,v8@6783854603267.877745 2.212104 5 good chromium@379308,v8@683223b4ba260.668652 2.064954 8 bad chromium@379309 259.923552 2.262146 5 bad chromium@379312 259.514415 1.442895 5 bad chromium@379318 261.375181 2.315373 5 bad chromium@379326 256.277267 3.332016 5 bad chromium@379343 260.048157 1.848121 5 bad Bisect job ran on: mac_hdd_perf_bisect Bug ID: 592305 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests dromaeo.domcoretraverse Test Metric: dom/dom Relative Change: 3.08% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/442 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018877013935002368 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/93e744a77766f8643d1216852ebf3a94713a4c5b commit 93e744a77766f8643d1216852ebf3a94713a4c5b Author: verwaest <verwaest@chromium.org> Date: Mon Mar 07 16:43:12 2016 Speed up indexed interceptor handling in the LookupIterator BUG= chromium:592305 LOG=n Review URL: https://codereview.chromium.org/1770833002 Cr-Commit-Position: refs/heads/master@{#34552} [modify] https://crrev.com/93e744a77766f8643d1216852ebf3a94713a4c5b/src/ic/ic.cc [modify] https://crrev.com/93e744a77766f8643d1216852ebf3a94713a4c5b/src/lookup.cc [modify] https://crrev.com/93e744a77766f8643d1216852ebf3a94713a4c5b/src/lookup.h
,
Mar 9 2016
,
Mar 9 2016
Issue 592301 has been merged into this issue.
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/79ccf34a78ea0e266e3a36ed63649ef49121f644 commit 79ccf34a78ea0e266e3a36ed63649ef49121f644 Author: verwaest <verwaest@chromium.org> Date: Thu Mar 10 10:55:46 2016 Inline calling into the interceptor into the IC callbacks rather than going through the LookupIterator. This is highly performance sensitive as there is no faster path; it's used directly by the IC. BUG= chromium:592305 LOG=n Review URL: https://codereview.chromium.org/1778493005 Cr-Commit-Position: refs/heads/master@{#34660} [modify] https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644/src/ic/handler-compiler.cc [modify] https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644/src/ic/ic.cc [modify] https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644/src/objects-inl.h [modify] https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644/src/objects.cc [modify] https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644/src/objects.h
,
Mar 11 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ericwilligers@chromium.org
, Mar 7 2016