New issue
Advanced search Search tips

Issue 592304 link

Starred by 0 users
Status: Duplicate
Merged: issue 591743
Owner:
ericwilligers@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10% regression in blink_perf.layout at 378837:378862

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016 
ChromiumPerf/chromium-rel-mac-retina/blink_perf.layout / layers_overlap_2d
ChromiumPerf/chromium-rel-mac-retina/blink_perf.layout / layers_overlap_3d
ChromiumPerf/linux-release/blink_perf.layout / layers_overlap_3d

Comment 1 by ericwilligers@chromium.org, Mar 7 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592304

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA363j_ggM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 7 2016

Mergedinto: 591743
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ )
Author  : wangxianzhu
Commit description:
  
Reason for revert:
Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect
scrollableArea of a layer to disappear.

Revert functional changes, but keep refactories.

BUG=591045

Original issue's description:
> Conditionally create PaintLayer's scrollable area object
>
> BUG= 467721 
>
> Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e
> Cr-Commit-Position: refs/heads/master@{#378247}

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 467721 

Review URL: https://codereview.chromium.org/1755243002

Cr-Commit-Position: refs/heads/master@{#378845}
Commit  : b772a3d31c12361e22a8d6950cbef821ac3dc7d5
Date    : Wed Mar 02 21:54:56 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378824         62.8932     0.877959    5           good
chromium@378835         64.6608     1.883945    5           good
chromium@378841         65.7256     1.403321    5           good
chromium@378844         64.623      0.471937    5           good
chromium@378845         69.851      0.676556    5           bad
chromium@378846         69.7292     0.589314    5           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 592304

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.layout
Test Metric: layers_overlap_3d/layers_overlap_3d
Relative Change: 10.87%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6285
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018877257616369872


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 7 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ )
Author  : wangxianzhu
Commit description:
  
Reason for revert:
Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect
scrollableArea of a layer to disappear.

Revert functional changes, but keep refactories.

BUG=591045

Original issue's description:
> Conditionally create PaintLayer's scrollable area object
>
> BUG= 467721 
>
> Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e
> Cr-Commit-Position: refs/heads/master@{#378247}

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 467721 

Review URL: https://codereview.chromium.org/1755243002

Cr-Commit-Position: refs/heads/master@{#378845}
Commit  : b772a3d31c12361e22a8d6950cbef821ac3dc7d5
Date    : Wed Mar 02 21:54:56 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378836         53.8326     1.10147     5           good
chromium@378842         54.3844     0.859731    5           good
chromium@378844         53.6414     0.942685    5           good
chromium@378845         58.977      0.922707    5           bad
chromium@378848         58.5522     0.901388    5           bad
chromium@378862         60.6904     1.415089    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592304

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.layout
Test Metric: layers_overlap_2d/layers_overlap_2d
Relative Change: 12.74%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1203
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018877283651795168


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 7 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ )
Author  : wangxianzhu
Commit description:
  
Reason for revert:
Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect
scrollableArea of a layer to disappear.

Revert functional changes, but keep refactories.

BUG=591045

Original issue's description:
> Conditionally create PaintLayer's scrollable area object
>
> BUG= 467721 
>
> Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e
> Cr-Commit-Position: refs/heads/master@{#378247}

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 467721 

Review URL: https://codereview.chromium.org/1755243002

Cr-Commit-Position: refs/heads/master@{#378845}
Commit  : b772a3d31c12361e22a8d6950cbef821ac3dc7d5
Date    : Wed Mar 02 21:54:56 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378836         62.222      0.915931    5           good
chromium@378842         61.7642     0.811951    5           good
chromium@378844         60.7314     1.288431    5           good
chromium@378845         68.2568     1.270146    5           bad
chromium@378848         66.9828     0.985694    5           bad
chromium@378862         69.1636     1.648683    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592304

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.layout
Test Metric: layers_overlap_3d/layers_overlap_3d
Relative Change: 11.16%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1204
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018877252220702208


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
►

Sign in to add a comment