New issue
Advanced search Search tips

Issue 592300 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 592077
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

21.6% regression in blink_perf.pywebsocket at 379162:379184

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592300

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA36_BvwoM


Bot(s) for this bug's original alert(s):

linux-release

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : rewrite_to_chrome_style: Rewrite references to members through the class
Author  : danakj
Commit description:
  
This catches references to members such as &ClassName::m_memberName to
rename the m_memberName correctly.

R=dcheng
BUG= 584091 

Review URL: https://codereview.chromium.org/1765783002

Cr-Commit-Position: refs/heads/master@{#379184}
Commit  : 435df50496bb28a8b27a398a084174d53f9f4ae6
Date    : Fri Mar 04 02:37:43 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379161         38.55       1.067295    18          good
chromium@379173         39.48       1.640732    5           good
chromium@379179         39.76       1.538831    5           good
chromium@379182         39.18       1.202913    5           good
chromium@379183         42.92       1.893938    5           good
chromium@379184         40.461111   14.603631   18          bad

Bisect job ran on: linux_perf_bisect
Bug ID: 592300

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.pywebsocket
Test Metric: fetch-send-arraybuffer-window-async-verify/fetch-send-arraybuffer-window-async-verify
Relative Change: 1.16%
Score: 0.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6283
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878313021213552


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Owner: danakj@chromium.org
Owner: ericwilligers@chromium.org
My CL is to the rewrite_to_chrome_style clang tool, not to chromium. Bisect is hitting the wrong CL.
Mergedinto: 592077
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378995         55.92       1.384558    5           good
chromium@379059         55.76       1.28569     5           good
chromium@379091         58.28       1.359044    5           good
chromium@379107         56.42       0.949737    5           good
chromium@379109         59.9        0.748331    5           good
chromium@379110         56.38       0.715542    5           good
chromium@379111         43.72       1.742699    5           bad
chromium@379115         44.92       1.497331    5           bad
chromium@379123         42.18       1.453272    5           bad
chromium@379251         47.46       1.608726    5           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 592300

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.pywebsocket
Test Metric: fetch-send-arraybuffer-window-async-verify/fetch-send-arraybuffer-window-async-verify
Relative Change: 15.13%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6290
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018712453395856736


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment