Issue metadata
Sign in to add a comment
|
5.8% regression in webrtc.getusermedia at 378871:379375 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 7 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Author : dgozman Commit description: Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} Commit : 924fe8af695e29594c55db971d793d4d931b337c Date : Thu Mar 03 22:19:29 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@378870 10616.0 25.13961 5 good chromium@378997 10645.6 70.290824 5 good chromium@379060 10628.8 36.265686 5 good chromium@379092 10628.8 24.396721 5 good chromium@379108 10641.6 50.485642 5 good chromium@379110 10610.4 24.099793 5 good chromium@379111 11292.0 166.25282 5 bad chromium@379112 11252.8 115.009565 5 bad chromium@379116 11294.4 94.851463 5 bad chromium@379123 11253.6 123.437434 5 bad chromium@379375 11280.0 134.877722 5 bad Bisect job ran on: android_nexus6_perf_bisect Bug ID: 592298 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer Relative Change: 6.25% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2003 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878403028433344 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 7 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Author : dgozman Commit description: Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} Commit : 924fe8af695e29594c55db971d793d4d931b337c Date : Thu Mar 03 22:19:29 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@378870 10668.8 11.09955 5 good chromium@378997 10618.4 22.378561 5 good chromium@379060 10643.2 62.890381 5 good chromium@379092 10644.8 41.607692 5 good chromium@379108 10662.4 27.942799 5 good chromium@379110 10646.4 45.834485 5 good chromium@379111 11372.8 126.914144 5 bad chromium@379112 11325.6 84.975291 5 bad chromium@379116 11207.2 98.889838 5 bad chromium@379123 11212.0 99.879928 5 bad chromium@379375 11315.2 123.138946 5 bad Bisect job ran on: android_nexus6_perf_bisect Bug ID: 592298 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer Relative Change: 6.06% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2004 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878396756753664 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ericwilligers@chromium.org
, Mar 7 2016