New issue
Advanced search Search tips

Issue 592295 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 592077
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.4% regression in blink_perf.parser at 379100:379151

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

ChromiumPerf/chromium-rel-mac-retina/blink_perf.parser / query-selector-all-id-deep
ChromiumPerf/linux-release/blink_perf.parser / query-selector-all-id-first
ChromiumPerf/chromium-rel-mac-retina/blink_perf.parser / query-selector-all-id-last

 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592295

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAv6afsQoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379123         1188.380924 48.958612   27          good
chromium@379139         1163.286726 45.802214   27          bad

Bisect job ran on: linux_perf_bisect
Bug ID: 592295

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser
Test Metric: query-selector-all-id-first/query-selector-all-id-first
Relative Change: 1.57%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6278
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878818292091824


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Mergedinto: 592077
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379099         14761.568826135.79036   5           good
chromium@379106         14779.602929127.90723   5           good
chromium@379109         14701.798837180.040849  5           good
chromium@379110         14591.776935293.003568  5           good
chromium@379111         12973.927166147.515901  5           bad
chromium@379112         13075.630062142.442066  5           bad
chromium@379125         13156.241608327.07853   5           bad
chromium@379151         12848.882345350.023481  5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592295

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser
Test Metric: query-selector-all-id-deep/query-selector-all-id-deep
Relative Change: 12.96%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1201
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878837366090496


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379099         14847.185062178.007456  8           good
chromium@379106         14466.635609922.20489   8           good
chromium@379109         14678.187335268.002917  5           good
chromium@379110         14239.090569717.746829  5           good
chromium@379111         12937.698063106.674834  5           bad
chromium@379112         12588.815714554.077322  8           bad
chromium@379125         13369.879613468.822311  5           bad
chromium@379151         12782.493347181.432832  5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592295

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser
Test Metric: query-selector-all-id-deep/query-selector-all-id-deep
Relative Change: 13.85%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1200
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878842729082176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379099         14552.591833473.162538  8           good
chromium@379106         14551.118864379.742555  5           good
chromium@379109         14851.72641175.946206   5           good
chromium@379110         14530.739893444.196356  5           good
chromium@379111         13316.378299374.539631  5           bad
chromium@379112         13573.183104389.055617  5           bad
chromium@379125         13699.859237497.139121  5           bad
chromium@379151         12980.849071431.227681  5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592295

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser
Test Metric: query-selector-all-id-last/query-selector-all-id-last
Relative Change: 9.99%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1202
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018878780926131760


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment