New issue
Advanced search Search tips

Issue 592291 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 592077
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.4% regression in blink_perf.shadow_dom at 379100:379113

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592291

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAv-7V6wkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Mergedinto: 592077
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379099         3.1204      0.071988    5           good
chromium@379106         3.1954      0.085278    5           good
chromium@379110         3.1578      0.072696    5           good
chromium@379111         3.4228      0.017768    5           bad
chromium@379112         3.418       0.031773    5           bad
chromium@379113         3.4162      0.046143    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592291

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.shadow_dom
Test Metric: shadow-style-share/shadow-style-share
Relative Change: 9.48%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1199
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018879240076119328


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ )
Author  : dgozman
Commit description:
  
Reason for revert:
Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406

Original issue's description:
> [DevTools] Postpone more agents instantiation until attached.
>
> To support multiple attached devtools, we have to instantiate
> individual agents on demand, rather than on creation.
> This patch moves most of agents, with only worker and inspector to go.
>
> BUG= 590878 
>
> Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304
> Cr-Commit-Position: refs/heads/master@{#378509}

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 590878 

Review URL: https://codereview.chromium.org/1761663003

Cr-Commit-Position: refs/heads/master@{#379111}
Commit  : 924fe8af695e29594c55db971d793d4d931b337c
Date    : Thu Mar 03 22:19:29 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379099         3.1666      0.040796    5           good
chromium@379106         3.0674      0.050698    5           good
chromium@379110         3.21175     0.094838    8           good
chromium@379111         3.4196      0.096345    5           bad
chromium@379112         3.407       0.038955    5           bad
chromium@379113         3.4604      0.078986    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 592291

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.shadow_dom
Test Metric: shadow-style-share/shadow-style-share
Relative Change: 9.28%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1198
Job details: https://chromeperf.appspot.com/buildbucket_job_status/None


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment