Issue metadata
Sign in to add a comment
|
13.2% regression in blink_perf.parser at 379087:379118 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 7 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Author : dgozman Commit description: Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} Commit : 924fe8af695e29594c55db971d793d4d931b337c Date : Thu Mar 03 22:19:29 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@379086 14306.924486559.584155 5 good chromium@379099 14299.328588423.423548 5 good chromium@379109 14573.567357282.383819 5 good chromium@379110 14506.16846245.064572 5 good chromium@379111 12544.837232167.897729 5 bad chromium@379113 12629.98075141.528642 5 bad chromium@379118 12365.071237222.200679 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 592285 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser Test Metric: query-selector-all-id-deep/query-selector-all-id-deep Relative Change: 13.57% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2020 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018879778655998400 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 7 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Author : dgozman Commit description: Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} Commit : 924fe8af695e29594c55db971d793d4d931b337c Date : Thu Mar 03 22:19:29 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@379040 14809.710248268.579787 5 good chromium@379086 14757.274032446.611064 5 good chromium@379099 14541.423647169.320915 8 good chromium@379109 14283.615783723.826397 8 good chromium@379110 14560.165059182.129422 5 good chromium@379111 12642.588596122.818347 8 bad chromium@379113 12663.959698222.702993 8 bad chromium@379118 12277.077393328.614015 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 592285 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.parser Test Metric: query-selector-all-id-deep/query-selector-all-id-deep Relative Change: 17.10% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2021 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018879746659921632 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ericwilligers@chromium.org
, Mar 7 2016