New issue
Advanced search Search tips

Issue 592281 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16% regression in dromaeo.domcorequery at 379308:379447

Project Member Reported by ericwilligers@chromium.org, Mar 7 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=592281

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAv-iytgoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-single

===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379307         10496.76343 158.805905  12          good
chromium@379308         10505.256819131.063702  8           good
chromium@379310         10336.15908846.426608   8           bad
chromium@379313         10305.846127115.291913  8           bad
chromium@379319         10327.96739 51.752323   8           bad
chromium@379331         10352.41144253.485081   5           bad

Bisect job ran on: win_perf_bisect
Bug ID: 592281

Test Command: python src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests dromaeo.domcorequery
Test Metric: dom/dom
Relative Change: 1.91%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6383
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018880253848528960


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Cc: dtseng@chromium.org
Owner: dtseng@chromium.org

=== Auto-CCing suspected CL author dtseng@chromium.org ===

Hi dtseng@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fix logic handling empty strings in tts.
Author  : dtseng
Commit description:
  
Previously, we explicitly stopped speech when encountering a call to speak only whitespace. However, since sometimes we get whitespace from an unreliable source, it can actually cause other utterances to be interrupted.

One such example is Sheets. When arrowing around, we observe some events resulting in empty speech which interrupts cell announcement.

Review URL: https://codereview.chromium.org/1762843002

Cr-Commit-Position: refs/heads/master@{#379308}
Commit  : 112cdcfa70a21b026abe0228c9b5ebb2fb287a3e
Date    : Fri Mar 04 17:53:19 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@379307         10551.691411125.804171  12          good
chromium@379308         10423.551325110.755913  12          bad
chromium@379310         10289.711093137.042672  8           bad
chromium@379313         10352.87307858.261836   5           bad
chromium@379319         10341.08207850.022859   8           bad
chromium@379331         10304.75266692.272601   8           bad

Bisect job ran on: win_perf_bisect
Bug ID: 592281

Test Command: python src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests dromaeo.domcorequery
Test Metric: dom/dom
Relative Change: 2.35%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6384
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018880222407439616


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Cc: nyerramilli@chromium.org
Labels: TE-Triaged
based on bisect results, dtseng@ could you please check the issue.
Status: Fixed (was: Assigned)
This has recovered.

Sign in to add a comment