New Tab page broken after download
Reported by
robexms2...@gmail.com,
Mar 7 2016
|
||||||||
Issue description<b>Chrome Version : <from About Google Chrome/Chromium or</b> 'about:version'> Version 49.0.2623.75 m (64-bit) URL :New Tab Description: In case that I open a new tab and insert a link to download a calendar RSS link Ex. https://amplusnet.shiftplanning.com/ical/0cf141aaf857fe9651df5c1974a85290.ics?1457306767271 After download finished the download .ics file the thumbs for the favorite /most visited websites will remain and react when the cursor is above but by clicking on it will not open the page. This happens even I close the download bar. The page will be broken. What steps will reproduce the problem? 1.Open new tab 2.Enter a download link for an rss calendar (.ics) and download it. 3.Try to click on one of the most visited thumb on the existing new tab page.
,
Mar 7 2016
,
Mar 7 2016
Hello, First of all sorry for my bad explanation (English is not my native language). So in simple way to say: The new tab you use to download the file will became unusable even if I move the cursor over the thumbs and react, if I click on them will not open the page. Video attached.
,
Mar 9 2016
Thanks for reporting! I can reproduce this problem on Mac Stable M48, but not on Mac Canary M50 or Linux Beta M49. Interesting.
,
Mar 18 2016
Any update on this case?
,
Mar 18 2016
I can't reproduce this anymore on the latest Chrome Stable on Win7 49.0.2623.87 (Official Build) m (32-bit) Could you try again if the problem still exists?
,
Mar 31 2016
,
Apr 14 2016
The bug is still on.
,
Apr 15 2016
Thanks for checking again! I can now reproduce it again too. Notes to self: The thumbnails sometimes still work after a download - seems that MostLikely thumbs still work, but TopSites ones don't? The fakebox always seems to break. Also happens on the local NTP.
,
Sep 5 2017
Theory: The download is kinda-sorta a navigation. This causes the NTP to lose its "Instant" status, i.e. it loses access to the embeddedSearch APIs. That would cause the fakebox and TopSites tiles to stop working.
,
Nov 30 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8 commit cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8 Author: Marc Treib <treib@chromium.org> Date: Mon Dec 04 16:25:08 2017 search::IsInstantNTP: Prefer committed over visible URL The visible URL doesn't always correspond to the actual page that's loaded. For example, if the user types in a URL that ends up being a download, then the visible URL corresponds to the download, but the NTP is still there and should remain functional. Bug: 592273 , 624410 Change-Id: Ib2e0a7df8658e55030ee5e67959a0ebc486e495d Reviewed-on: https://chromium-review.googlesource.com/800931 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521359} [modify] https://crrev.com/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8/chrome/browser/search/search.cc [modify] https://crrev.com/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8/chrome/browser/search/search.h [modify] https://crrev.com/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8/chrome/browser/search/search_unittest.cc [modify] https://crrev.com/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc
,
Dec 4 2017
Alright, this should fix the issue. Let's see if I broke anything else in the process...
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99d09111f96d38651656311f16832742352f0f34 commit 99d09111f96d38651656311f16832742352f0f34 Author: Marc Treib <treib@chromium.org> Date: Thu Dec 07 14:46:38 2017 Local NTP download test: don't leak downloaded files Before this CL, LocalNTPTest.EmbeddedSearchAPIAfterDownload stored a test download file into the system's actual downloads folder, and left it there after the test ended. This CL instead sets up a temporary folder as the download folder. Bug: 592273 Change-Id: I27aa103b4c69b7c6a6bba755f74ee0bcb9fe2c84 Reviewed-on: https://chromium-review.googlesource.com/814115 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#522424} [modify] https://crrev.com/99d09111f96d38651656311f16832742352f0f34/chrome/browser/ui/search/local_ntp_browsertest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ssamanoori@chromium.org
, Mar 7 20162.6 MB
2.6 MB Download