content/test/gpu_memory_buffer_factory_test_template.h should move to content/common/gpu |
||
Issue descriptioncontent/common/gpu/gpu_memory_buffer_factory_io_surface_unittest.cc content/common/gpu/gpu_memory_buffer_factory_surface_texture_unittest.cc content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap_unittest.cc depend on content/test/gpu_memory_buffer_factory_test_template.h In the interest of componentization, content/common/gpu should not depend on other parts of content. To that end, I would suggest moving content/test/gpu_memory_buffer_factory_test_template.h to content/common/gpu.
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbdf20c9eec45a535156daf94b94db89ace868f5 commit dbdf20c9eec45a535156daf94b94db89ace868f5 Author: markdittmer <markdittmer@chromium.org> Date: Fri Mar 11 05:12:13 2016 Migrate gpu_memory_buffer_factory_test_template to content/common/gpu Context: As part of a plan to move content/common/gpu out of content, we are eliminating deps from content/common/gpu to elsewhere in content. BUG= 592254 Review URL: https://codereview.chromium.org/1784723003 Cr-Commit-Position: refs/heads/master@{#380511} [modify] https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5/content/common/gpu/gpu_memory_buffer_factory_io_surface_unittest.cc [modify] https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5/content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap_unittest.cc [modify] https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5/content/common/gpu/gpu_memory_buffer_factory_surface_texture_unittest.cc [rename] https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5/content/common/gpu/gpu_memory_buffer_factory_test_template.h [modify] https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5/content/content_tests.gypi
,
Mar 11 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by fsam...@chromium.org
, Mar 6 2016