New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592185 link

Starred by 1 user
Status: Fixed
Owner:
schenney@chromium.org
Closed: Aug 2016
Cc:
pdr@chromium.org
█ ymalik@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test fast/repaint/fixed-right-in-page-scale.html is failing

Project Member Reported by dpranke@chromium.org, Mar 5 2016 
The following layout test is failing on all platforms

fast/repaint/fixed-right-in-page-scale.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Frepaint%2Ffixed-right-in-page-scale.html

I have no idea when this started happening, but it appears to always fail at first and then pass on retry.

@pdr, any idea who should look at this?

Comment 1 by pdr@chromium.org, Mar 5 2016

Cc: bokan@chromium.org
Components: Blink>Scroll
Owner: ymalik@chromium.org
Status: Assigned (was: Untriaged)
This is a tough one, nothing obvious is going wrong.

I think this could be related to  https://crbug.com/489206 . In https://codereview.chromium.org/1712743002, a sibling test was modified (fixed-right-bottom-in-page-scale.html) but not this test. The reverted patch also contains some scale / scroll type code that could be related.

@ymalik@chromium.org, can you please take a look?

Comment 3 by ymalik@chromium.org, Mar 7 2016

Cc: -bokan@chromium.org ymalik@chromium.org
Owner: bokan@chromium.org
Hmm, I am not sure what's going wrong here.

The sibling test (fixed-right-bottom-in-page-scale.html) was modified in https://codereview.chromium.org/1712743002 because the call to window.scrollTo would not scroll the visual viewport after window.scroll properties were made relative to the layout viewport (now revered).

In this test, we scroll first and then zoom, so the same issue doesn't apply (I don't think this is related to scale / scroll changes in that patch).

Also, I can't repro the failure locally on my Linux machine. 

Assigning to @bokan to see what he thinks.

Comment 4 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 5 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.

Comment 6 by schenney@chromium.org, Aug 22 2016

Cc: bokan@chromium.org
Owner: schenney@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9b646a58c18a16b8c284e11e993f6242dcd915b

commit e9b646a58c18a16b8c284e11e993f6242dcd915b
Author: schenney <schenney@chromium.org>
Date: Wed Aug 24 20:37:25 2016

Revert an incorrect TestExpectations change

TBR=pdr@chromium.org
BUG= 592185 

Review-Url: https://codereview.chromium.org/2278653002
Cr-Commit-Position: refs/heads/master@{#414126}

[modify] https://crrev.com/e9b646a58c18a16b8c284e11e993f6242dcd915b/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by schenney@chromium.org, Aug 25 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment