New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592168 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome app icon isn't displayed fully on Shelf

Project Member Reported by songsuk@chromium.org, Mar 5 2016

Issue description

Chrome Version       : 50.0.2661.14
Platform             : 7978.5.0 - veyron-minnie, Squawks

What steps will reproduce the problem?
1. open the Launcher from the Shelf
2. serach "sudoku", and install a sudoku via the Launcher
3. run the "sudoku"
4. open the Launcher again, and check the sudoku icon 
5. cursor on the icon, and two fingers tap on Touchpad to open the context menu 

What is the expected result?
On step#4&5, the icon should appear fully and context menu should appear.

What happens instead?
On step#4, the icon size is small. 
On step#5, nothing happens 


Please provide any additional information below. Attach a screenshot if
possible.

Not reproducible in Chrome 49.0.2623.75/ CrOS 7834.52.0 - Paine
 
Launcher.png
59.2 KB View Download
Cc: dhadd...@chromium.org
Cc: mgiuca@chromium.org
Components: UI>Shell>Launcher
Also observed this issue for Duolingo app. App icon is not displayed in full size.
Cc: kuscher@chromium.org
Issue reproduced on latest beta build 7978.29.0 / 50.0.2661.50
Cc: glevin@chromium.org
Owner: r...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Chrome app icon isn't displayed fully on Shelf (was: Chrome app icon isn't displayed fully on Launcher)
Owner: glevin@chromium.org

Comment 6 by glevin@chromium.org, Apr 22 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcf7574721f7393dd33469fe476999ab50a35075

commit bcf7574721f7393dd33469fe476999ab50a35075
Author: glevin <glevin@chromium.org>
Date: Thu May 05 13:35:55 2016

Don't return installed apps in webstore searches in Launcher

BUG= 592168 
TEST=Open Launcher, search for and install Sudoku app, launch it.
Reopen Launcher, observer that app icon on Start Page looks right.

In the Launcher search, webstore app results used the same internal id
as installed apps.  Sometimes the wrong time of result object would get
cached in the Mixer, and a webstore result (smaller icon, no context
menu) would end up on the Start Page.

This CL changes internal id scheme for webstore app results, and
explicitly removes installed apps from results returned by webstore
provider.

Review-Url: https://codereview.chromium.org/1936953002
Cr-Commit-Position: refs/heads/master@{#391791}

[modify] https://crrev.com/bcf7574721f7393dd33469fe476999ab50a35075/chrome/browser/ui/app_list/app_list_controller_delegate.h
[modify] https://crrev.com/bcf7574721f7393dd33469fe476999ab50a35075/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc
[modify] https://crrev.com/bcf7574721f7393dd33469fe476999ab50a35075/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
[modify] https://crrev.com/bcf7574721f7393dd33469fe476999ab50a35075/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
[modify] https://crrev.com/bcf7574721f7393dd33469fe476999ab50a35075/chrome/browser/ui/app_list/search/webstore/webstore_result.h

Labels: -M-50 M-52
Issue reproduced on TOT  8282.0.0 / 52.0.2724.0

1. Install Sudoku app from webstore
2. Open the app from Launcher
3. Open launcher again
4. Icon is not displayed fully
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on TOT (8312.0.0, 52.0.2733.0)

Sign in to add a comment