New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592164 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK fail in render_widget.cc(1090) re: plugin resize

Project Member Reported by wkorman@chromium.org, Mar 5 2016

Issue description

Breakout from http://crbug.com/590856 -- unsure whether related, but potentially plugin resize lifecycle issue, and so filing for subsequent investigation.

Repro steps:
- desktop debug build, config'd to handle plugins like android (see patch below, which may or may not actually be required)
- open deepika.com, scroll around, open dev tools, size to Nexus 5X with the device simulator button in the dev tools top button bar, scroll around, close dev tools which will cause page to resize to normal desktop size

[1:1:0304/163213:FATAL:render_widget.cc(1090)] Check failed: !params.needs_resize_ack || !next_paint_is_resize_ack(). 
#0 0x7f7a1236789e base::debug::StackTrace::StackTrace()
#1 0x7f7a123c2c6f logging::LogMessage::~LogMessage()
#2 0x7f7a0e03fb12 content::RenderWidget::Resize()
#3 0x7f7a0e03c432 content::RenderWidget::OnResize()
#4 0x7f7a0e01907d content::RenderViewImpl::OnResize()
#5 0x7f7a0e04b8c9 _ZN4base20DispatchToMethodImplIPN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEJS4_EJLm0EEEEvRKT_T0_RKSt5tupleIJDpT1_EENS_13IndexSequenceIJXspT2_EEEE
#6 0x7f7a0e04b825 _ZN4base16DispatchToMethodIPN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEJS4_EEEvRKT_T0_RKSt5tupleIJDpT1_EE
#7 0x7f7a0e04b7cf _ZN3IPC16DispatchToMethodIN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEvSt5tupleIJS3_EEEEvPT_T0_PT1_RKT2_
#8 0x7f7a0e044d94 _ZN3IPC8MessageTI19ViewMsg_Resize_MetaSt5tupleIJN7content12ResizeParamsEEEvE8DispatchINS3_12RenderWidgetES8_vMS8_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#9 0x7f7a0e03ac9f content::RenderWidget::OnMessageReceived()
#10 0x7f7a0e01104d content::RenderViewImpl::OnMessageReceived()
#11 0x7f7a0acd6b0b IPC::MessageRouter::RouteMessage()
#12 0x7f7a0d9a66b8 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage()
#13 0x7f7a0acd6a8e IPC::MessageRouter::OnMessageReceived()
#14 0x7f7a0d9a9b9d content::ChildThreadImpl::OnMessageReceived()
#15 0x7f7a0ac9d423 IPC::ChannelProxy::Context::OnDispatchMessage()
#16 0x7f7a0aca1d71 _ZN4base8internal15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEE3RunIJS7_EEEvPS4_DpOT_
#17 0x7f7a0aca1ca1 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEEEE8MakeItSoIJPS5_S8_EEEvSB_DpOT_
#18 0x7f7a0aca1c50 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS6_7MessageEEEEFvPS8_SB_EJSF_SB_EEENS0_12InvokeHelperILb0EvSE_EEFvvEE3RunEPNS0_13BindStateBaseE
#19 0x7f7a1234f02e base::Callback<>::Run()
#20 0x7f7a1236cd5e base::debug::TaskAnnotator::RunTask()
#21 0x7f79fa738372 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#22 0x7f79fa7362f2 scheduler::TaskQueueManager::DoWork()
#23 0x7f79fa73dabe _ZN4base8internal15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEE3RunIJRKS4_RKbEEEvPS3_DpOT_
#24 0x7f79fa73d9ba _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEE8MakeItSoINS_7WeakPtrIS4_EEJRKS5_RKbEEEvS8_T_DpOT0_
#25 0x7f79fa73d938 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#26 0x7f7a1234f02e base::Callback<>::Run()
#27 0x7f7a1236cd5e base::debug::TaskAnnotator::RunTask()
#28 0x7f7a123def8f base::MessageLoop::RunTask()
#29 0x7f7a123df218 base::MessageLoop::DeferOrRunPendingTask()
#30 0x7f7a123df3e2 base::MessageLoop::DoWork()
#31 0x7f7a123f0bc3 base::MessagePumpDefault::Run()
#32 0x7f7a123de9bf base::MessageLoop::RunHandler()
#33 0x7f7a12455b64 base::RunLoop::Run()
#34 0x7f7a123dda64 base::MessageLoop::Run()
#35 0x7f7a0e069638 content::RendererMain()
#36 0x7f7a0cc6f416 content::RunZygote()
#37 0x7f7a0cc6f6c0 content::RunNamedProcessTypeMain()
#38 0x7f7a0cc71cad content::ContentMainRunnerImpl::Run()
#39 0x7f7a0cc6ea02 content::ContentMain()
#40 0x7f7a1302ba82 ChromeMain
#41 0x7f7a1302ba32 main
#42 0x7f79ff976ec5 __libc_start_main
#43 0x7f7a1302b935 <unknown>

Received signal 6
#0 0x7f7a1236789e base::debug::StackTrace::StackTrace()
#1 0x7f7a123673df base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f7a03b7d340 <unknown>
#3 0x7f79ff98bcc9 gsignal
#4 0x7f79ff98f0d8 abort
#5 0x7f7a12364466 base::debug::(anonymous namespace)::DebugBreak()
#6 0x7f7a12364448 base::debug::BreakDebugger()
#7 0x7f7a123c2fbd logging::LogMessage::~LogMessage()
#8 0x7f7a0e03fb12 content::RenderWidget::Resize()
#9 0x7f7a0e03c432 content::RenderWidget::OnResize()
#10 0x7f7a0e01907d content::RenderViewImpl::OnResize()
#11 0x7f7a0e04b8c9 _ZN4base20DispatchToMethodImplIPN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEJS4_EJLm0EEEEvRKT_T0_RKSt5tupleIJDpT1_EENS_13IndexSequenceIJXspT2_EEEE
#12 0x7f7a0e04b825 _ZN4base16DispatchToMethodIPN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEJS4_EEEvRKT_T0_RKSt5tupleIJDpT1_EE
#13 0x7f7a0e04b7cf _ZN3IPC16DispatchToMethodIN7content12RenderWidgetEMS2_FvRKNS1_12ResizeParamsEEvSt5tupleIJS3_EEEEvPT_T0_PT1_RKT2_
#14 0x7f7a0e044d94 _ZN3IPC8MessageTI19ViewMsg_Resize_MetaSt5tupleIJN7content12ResizeParamsEEEvE8DispatchINS3_12RenderWidgetES8_vMS8_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#15 0x7f7a0e03ac9f content::RenderWidget::OnMessageReceived()
#16 0x7f7a0e01104d content::RenderViewImpl::OnMessageReceived()
#17 0x7f7a0acd6b0b IPC::MessageRouter::RouteMessage()
#18 0x7f7a0d9a66b8 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage()
#19 0x7f7a0acd6a8e IPC::MessageRouter::OnMessageReceived()
#20 0x7f7a0d9a9b9d content::ChildThreadImpl::OnMessageReceived()
#21 0x7f7a0ac9d423 IPC::ChannelProxy::Context::OnDispatchMessage()
#22 0x7f7a0aca1d71 _ZN4base8internal15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEE3RunIJS7_EEEvPS4_DpOT_
#23 0x7f7a0aca1ca1 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEEEE8MakeItSoIJPS5_S8_EEEvSB_DpOT_
#24 0x7f7a0aca1c50 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS6_7MessageEEEEFvPS8_SB_EJSF_SB_EEENS0_12InvokeHelperILb0EvSE_EEFvvEE3RunEPNS0_13BindStateBaseE
#25 0x7f7a1234f02e base::Callback<>::Run()
#26 0x7f7a1236cd5e base::debug::TaskAnnotator::RunTask()
#27 0x7f79fa738372 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#28 0x7f79fa7362f2 scheduler::TaskQueueManager::DoWork()
#29 0x7f79fa73dabe _ZN4base8internal15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEE3RunIJRKS4_RKbEEEvPS3_DpOT_
#30 0x7f79fa73d9ba _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEE8MakeItSoINS_7WeakPtrIS4_EEJRKS5_RKbEEEvS8_T_DpOT0_
#31 0x7f79fa73d938 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#32 0x7f7a1234f02e base::Callback<>::Run()
#33 0x7f7a1236cd5e base::debug::TaskAnnotator::RunTask()
#34 0x7f7a123def8f base::MessageLoop::RunTask()
#35 0x7f7a123df218 base::MessageLoop::DeferOrRunPendingTask()
#36 0x7f7a123df3e2 base::MessageLoop::DoWork()
#37 0x7f7a123f0bc3 base::MessagePumpDefault::Run()
#38 0x7f7a123de9bf base::MessageLoop::RunHandler()
#39 0x7f7a12455b64 base::RunLoop::Run()
#40 0x7f7a123dda64 base::MessageLoop::Run()
#41 0x7f7a0e069638 content::RendererMain()
#42 0x7f7a0cc6f416 content::RunZygote()
#43 0x7f7a0cc6f6c0 content::RunNamedProcessTypeMain()
#44 0x7f7a0cc71cad content::ContentMainRunnerImpl::Run()
#45 0x7f7a0cc6ea02 content::ContentMain()
#46 0x7f7a1302ba82 ChromeMain
#47 0x7f7a1302ba32 main
#48 0x7f79ff976ec5 __libc_start_main
#49 0x7f7a1302b935 <unknown>
  r8: 00007ffd6dd0f010  r9: 0000000000000000 r10: 0000000000000008 r11: 0000000000000202
 r12: 00007f7a1302b90c r13: 00007ffd6dd14e70 r14: 0000000000000000 r15: 0000000000000000
  di: 0000000000000001  si: 0000000000000001  bp: 00007ffd6dd0f450  bx: 0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffd6dd0f318
  ip: 00007f79ff98bcc9 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]


BEGIN PATCH

diff --git a/cc/tiles/tile_manager.cc b/cc/tiles/tile_manager.cc
index 418e7a9..a77166d 100644
--- a/cc/tiles/tile_manager.cc
+++ b/cc/tiles/tile_manager.cc
@@ -201,9 +201,9 @@ void InsertNodesForRasterTask(TaskGraph* graph,
 
     // Tasks are inserted in priority order, so existing decode tasks should
     // already be FOREGROUND if this is a high priority task.
-    DCHECK(decode_it == graph->nodes.end() || !high_priority ||
-           static_cast<uint16_t>(TASK_CATEGORY_FOREGROUND) ==
-               decode_it->category);
+    // DCHECK(decode_it == graph->nodes.end() || !high_priority ||
+    //        static_cast<uint16_t>(TASK_CATEGORY_FOREGROUND) ==
+    //            decode_it->category);
 
     if (decode_it == graph->nodes.end()) {
       InsertNodeForTask(graph, decode_task, decode_task_category, priority, 0u);
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 8486b3e..e74e6d8 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -556,39 +556,12 @@ bool ChromeContentRendererClient::OverrideCreatePlugin(
     const WebPluginParams& params,
     WebPlugin** plugin) {
   std::string orig_mime_type = params.mimeType.utf8();
-#if defined(ENABLE_EXTENSIONS)
-  if (!ChromeExtensionsRendererClient::GetInstance()->OverrideCreatePlugin(
-          render_frame, params)) {
-    return false;
-  }
-#endif
 
   GURL url(params.url);
-#if defined(ENABLE_PLUGINS)
-  ChromeViewHostMsg_GetPluginInfo_Output output;
-  WebString top_origin = frame->top()->securityOrigin().toString();
-  render_frame->Send(new ChromeViewHostMsg_GetPluginInfo(
-      render_frame->GetRoutingID(), url, blink::WebStringToGURL(top_origin),
-      orig_mime_type, &output));
-  *plugin = CreatePlugin(render_frame, frame, params, output);
-#else  // !defined(ENABLE_PLUGINS)
-
-#if defined(OS_ANDROID)
-  if (plugins::MobileYouTubePlugin::IsYouTubeURL(url, orig_mime_type)) {
-    base::StringPiece template_html(
-        ResourceBundle::GetSharedInstance().GetRawDataResource(
-            IDR_MOBILE_YOUTUBE_PLUGIN_HTML));
-    *plugin = (new plugins::MobileYouTubePlugin(render_frame, frame, params,
-                                                template_html))->plugin();
-    return true;
-  }
-#endif  // defined(OS_ANDROID)
-
   PluginUMAReporter::GetInstance()->ReportPluginMissing(orig_mime_type, url);
   *plugin = NonLoadablePluginPlaceholder::CreateNotSupportedPlugin(
                 render_frame, frame, params)->plugin();
 
-#endif  // defined(ENABLE_PLUGINS)
   return true;
 }

 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 6 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment