search icon in omnibox is low-dpi with material design top chrome |
|||
Issue descriptionLook how pixely the magnification icon is:
,
Mar 7 2016
LocationBarViewMac::OnChanged() updates the location_icon_decoration_ to show the search icon (actually, whatever icon is returned by OmniboxViewMac::ImageForResource(omnibox_view_->GetIcon())). ImageForResource() simply returns the result of calling ResourceBundle::GetNativeImageNamed(). GetNativeImageNamed(), which is overridden in resource_bundle_mac.mm, has a note about Material Design images overriding the same image from the standard packs. However, in the case of an MD match the returned NSImage contains only a single representation, regardless of how many MD packs at different scale factors there are. Because of the MD resource pack load order, that single representation is always the 1x version.
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/945e2bc8771685c37cfcb0fa6b855d2afefc05ed commit 945e2bc8771685c37cfcb0fa6b855d2afefc05ed Author: shrike <shrike@chromium.org> Date: Mon Mar 07 20:50:45 2016 Make sure images loaded from MD resource packs contain all reps (Mac). A bug in GetNativeImageNamed() causes an early out when collecting image representations from MD packs. The result is NSImages containing just the 1x representation. BUG= 592161 Review URL: https://codereview.chromium.org/1771963002 Cr-Commit-Position: refs/heads/master@{#379632} [modify] https://crrev.com/945e2bc8771685c37cfcb0fa6b855d2afefc05ed/ui/base/resource/resource_bundle_mac.mm
,
Mar 7 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Mar 5 2016