New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592140 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 590229

Blocking:
issue 617655
issue 377805



Sign in to add a comment

Make failures in host_info step turn the build a non-red color.

Project Member Reported by aiolos@chromium.org, Mar 4 2016

Issue description

While sheriffing yesterday and today, I ran into multiple devices being blacklisted, which resulted in host_info and all tests run on that device to be red. But redness implies that the test itself is broken instead of there being an infra/device issue.

When I'm sheriffing, I always look into purple builds before the red ones because: A) purple builds generally affect more than one test, so there is more data being lost while the issue continues. B) purple builds can hide other failures, and C) purple builds are generally faster for me to handle than red ones since they usually require hand off to infra.

From my experience, host_info failing is generally caused by a device being blacklisted for hw or other non-test related issues, causes multiple performance tests to not run, and has to get handed off to Infra for debugging/fixing of the issue. It would be helpful if these failures were a different color than the other failing tests, at least for the host_info step and the build color, so that they can get prioritized by our sheriffs.

I'd be fine with it being purple, but don't know how infra would feel about that since some of the tests are likely still running (and passing).
 

Comment 1 by smut@chromium.org, Mar 24 2016

Labels: -Infra Infra-Android OS-Android
Status: Available (was: Untriaged)
We will discuss this with our team today in our weekly meeting.

Comment 3 by stip@chromium.org, Mar 24 2016

host_info should return purple. Whether that fails the *build* is a separate issue that we can discuss.
host_info ought to be more dramatically changed.
Owner: bpastene@chromium.org
Status: Assigned (was: Available)
Ben was thinking about deleting the host-info step, so I'll assign him to this.

Do you have any examples of bad builds that were red but should have been purple?
I don't have a link, but on the perf waterfall we use the host_info step to check that:

* All the same type of device are connected to the host (all n7s, we've had bugs where someone accidentally plugged in n4+n7 to the same host)
* All the same type of OS (we've had problems where someone flashed the phone to the wrong build, and in particular we lost a lot of data when someone accidentally flashed a device to a non-svelte build)

These should both turn the step purple.

I agree with #4 that host_info should be more dramatically changed. Also, in the long term, I think swarming dimensions are a better solution to the problems I listed.

Comment 7 by aiolos@chromium.org, Mar 24 2016

I'm not really sure what you're asking for. The issue is that device failures (ie a device gets blacklisted because of permissions, or a bad connection, etc) get recorded as red (test failures) instead of an issue with the infrastructure.

Please don't delete the host-info step without a suitable replacement for seeing device issues. I have used it many times to determine that benchmarks were failing due to a blacklisted device, and why. Just removing it would make perf sheriffing much harder.

Especially since all benchmarks being red on a given device often, but not always, means that the device was unavailable. It has occasionally also meant that we had a cascading failure in the telemetry harness. Without the host_info, it would have been much harder to debug those.
Following up on aiolos's comment, I don't see host_info step running on our current builds:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29/builds/268

Anyone know what happened?
Some of the android perf bots don't run host_info, some do. See https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chromium.perf.json for the list that do. That's partly the reason I'd like to remove that step. If some of these bots have been running fine for a while now without it, why keep it?

The other reason I want to see it gone is because the 'device issues' you'd want to see are already there in the device_status_check step. (host_info essentially just calls that same script again) Why not fold whatever extra device & error reporting is needed into the original step?
Re #9: Can you confirm the problems I listed in #6 are caught by device_status_check? These are really critical issues for perf, the one where we lost the svelte data because of a bad flash lost a ton of data which we really needed for milestone launch review.
To clarify: the bots have not been "running fine", we've been running blind without critical checks that we are testing the correct device and OS.
But back to the original issue, yeah we can (and should) turn some colors purple if devices fail. At the least, I'll look into that.
re comment #10: device_status_check currently doesn't catch those problems but it certainly can, and that's what I'm proposing. What say we add a flag to that step telling it to fail loudly if the devices aren't homogenous? Or maybe just pass general device & host info output from device_status_check into host_info and let it run all the checking it needs to from there. Either option would be an improvement, I think, from what it currently does.
Re #13 that sounds great to me
I'm happy with either option from #13.
Blocking: 377805
Blockedon: 590229
Components: Infra>Client>Android
Labels: -Infra-Android
Blocking: 617655
Let's look at this as part of the fixit.

Ben, if you're not going to have time to do this in the next few weeks, I'd be happy to find someone on my team to do it.
Ben: are you going to have a chance to look at this?
Probably not any time soon. Feel free to reassign.
Cc: bpastene@chromium.org
Owner: rnep...@chromium.org
I do not think folding all of host_info into device_status_check is the correct route. It has some checks for get_free_disk_space on the host; which do not fit well into device_status_check since it is only checking for android device status. I will work on the other solution of using the output from device_status instead of having host_info call device_status directly.

We could also move the device type matching to device_status_check and keep host_info around for host-related things (such as disk space free).


I think host_info calling device_status could be ok; the bigger problem is with host_info doing the recovery parts of device_status_check.
Oh, ok then. I will have this call the devil one.
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4991dac3c60adfa126c70b3988ea4d2f5456351d

commit 4991dac3c60adfa126c70b3988ea4d2f5456351d
Author: rnephew <rnephew@chromium.org>
Date: Wed Jul 06 19:38:16 2016

[Android] Make host_info.py use device_status.py instead of bb_device_status_check.py

BUG= 592140 

Review-Url: https://codereview.chromium.org/2106063006
Cr-Commit-Position: refs/heads/master@{#403941}

[modify] https://crrev.com/4991dac3c60adfa126c70b3988ea4d2f5456351d/testing/scripts/common.py
[modify] https://crrev.com/4991dac3c60adfa126c70b3988ea4d2f5456351d/testing/scripts/host_info.py

What else do we need to do to finish this? Make the recipe handle the infra exit code?
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/36cbc8822d8db7930985047241e90a2e6f96c17e

commit 36cbc8822d8db7930985047241e90a2e6f96c17e
Author: rnephew <rnephew@chromium.org>
Date: Thu Jul 28 21:25:18 2016

[Android] Move host_info from test config to recipe step for android perf bots.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2192563004

[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[add] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e/scripts/slave/recipes/android/perf.py

Project Member

Comment 29 by bugdroid1@chromium.org, Jul 28 2016

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 28 2016

Project Member

Comment 31 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bb1d580272c1f1908ef8fc94ed5e93a37a79ab37

commit bb1d580272c1f1908ef8fc94ed5e93a37a79ab37
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 28 21:46:13 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e [Android] Move host_info from test config to recipe step for android perf bots. (rnephew@chromium.org)

R=rnephew@chromium.org
BUG= 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191973002

[modify] https://crrev.com/bb1d580272c1f1908ef8fc94ed5e93a37a79ab37/infra/config/recipes.cfg

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8089c423fec7d2fcf3cc472de776c42cd307eefc

commit 8089c423fec7d2fcf3cc472de776c42cd307eefc
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 28 22:06:21 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/36cbc8822d8db7930985047241e90a2e6f96c17e [Android] Move host_info from test config to recipe step for android perf bots. (rnephew@chromium.org)
  https://crrev.com/3e56c94cfbbaee3d53f06782ce3dee6a7c92a8f6 swarming: Fix 'collect' step if verbose mode is used. (vadimsh@chromium.org)

R=vadimsh@chromium.org,rnephew@chromium.org,martiniss@chromium.org
BUG= 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191923003

[modify] https://crrev.com/8089c423fec7d2fcf3cc472de776c42cd307eefc/infra/config/recipes.cfg

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7

commit 5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 29 00:01:41 2016

[Android] Add step text for host_info when failures are detected.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2191853004

[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7/scripts/slave/recipes/android/perf.expected/test_failure.json

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 29 2016

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b980b6fb7bd01f8d8f121bb47c131fb1d12e2b4f

commit b980b6fb7bd01f8d8f121bb47c131fb1d12e2b4f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 29 00:16:27 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/5fc11d3833748cf6d6e39e48500fd47dd6dd8ad7 [Android] Add step text for host_info when failures are detected. (rnephew@chromium.org)

R=rnephew@chromium.org
BUG= 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2194723002

[modify] https://crrev.com/b980b6fb7bd01f8d8f121bb47c131fb1d12e2b4f/infra/config/recipes.cfg

Project Member

Comment 36 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0dc697a670de04be1a15bd79bafef3aa0aad803

commit e0dc697a670de04be1a15bd79bafef3aa0aad803
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 29 14:24:52 2016

[Android] Remove host_info from chromium.perf.json testing config.

It is run via recipes now since it is suppose to run on every android bot
similar to device_status and device_recovery.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2193003002
Cr-Commit-Position: refs/heads/master@{#408635}

[modify] https://crrev.com/e0dc697a670de04be1a15bd79bafef3aa0aad803/testing/buildbot/chromium.perf.json

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7dbd97def26032d65206d7dd19aa7b09d98c5cc6

commit 7dbd97def26032d65206d7dd19aa7b09d98c5cc6
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 29 18:49:25 2016

[Android] Fix failures not being logged on host_info step.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2193843003

[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.py

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7dbd97def26032d65206d7dd19aa7b09d98c5cc6

commit 7dbd97def26032d65206d7dd19aa7b09d98c5cc6
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 29 18:49:25 2016

[Android] Fix failures not being logged on host_info step.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2193843003

[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6/scripts/slave/recipes/android/perf.py

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 29 2016

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/057dd5b7d3422ecff022f1a0ac913a2b7b98ea49

commit 057dd5b7d3422ecff022f1a0ac913a2b7b98ea49
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 29 19:21:42 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2bf1954974c343e25e4f37858107051a90670c5e [libfuzzer] more script arguments tweaking (aizatsky@chromium.org)
  https://crrev.com/7dbd97def26032d65206d7dd19aa7b09d98c5cc6 [Android] Fix failures not being logged on host_info step. (rnephew@chromium.org)

R=rnephew@chromium.org,aizatsky@chromium.org
BUG= 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2195823002

[modify] https://crrev.com/057dd5b7d3422ecff022f1a0ac913a2b7b98ea49/infra/config/recipes.cfg

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/18ec037fcdf5072a4d169859adfc4467335bba5d

commit 18ec037fcdf5072a4d169859adfc4467335bba5d
Author: rnephew <rnephew@chromium.org>
Date: Tue Aug 02 14:27:19 2016

[Android] Add failures to results log line for Host Info step.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2204643002

[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d/scripts/slave/recipes/android/perf.py

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 2 2016

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/50303508d701a6d74a7f5e15c96a65a9049887ec

commit 50303508d701a6d74a7f5e15c96a65a9049887ec
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 02 14:46:30 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/18ec037fcdf5072a4d169859adfc4467335bba5d [Android] Add failures to results log line for Host Info step. (rnephew@chromium.org)

R=rnephew@chromium.org
BUG= 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2203033003

[modify] https://crrev.com/50303508d701a6d74a7f5e15c96a65a9049887ec/infra/config/recipes.cfg

Status: Fixed (was: Assigned)
Project Member

Comment 45 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/47e92bc8f5032a745175810c0f7096e4b3d7d3b2

commit 47e92bc8f5032a745175810c0f7096e4b3d7d3b2
Author: rnephew <rnephew@chromium.org>
Date: Fri Aug 05 16:34:50 2016

[Android] Pass known devices file path to host info to detect missing devices.

BUG= 592140 

Review-Url: https://codereview.chromium.org/2222533003

[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2/scripts/slave/recipes/android/perf.expected/test_failure.json

Project Member

Comment 46 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/653ab70c50df6468b54af290a5e4ae2070067dbe

commit 653ab70c50df6468b54af290a5e4ae2070067dbe
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Aug 05 19:05:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4a1518cbd73f73b7842e80603396746aa49468d2 [Android] Add recipe code to run chrome telemetry browser tests. (mikecase@chromium.org)
  https://crrev.com/448c0c7029e4f4d6cd8381032800c65fc839bca0 [Android] Run result_details logic in a finally block. (jbudorick@chromium.org)
  https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2 [Android] Pass known devices file path to host info to detect missing devices. (rnephew@chromium.org)
  https://crrev.com/e93a9b8a319982bbab04851673467a375ddd3730 [cronet] Update PERF_IDs for new builders. (jbudorick@chromium.org)
  https://crrev.com/ef300a91ffa556e0b7eeed363b926aeea9eb3a40 Revert of Removing old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2219653003/ ) (martiniss@chromium.org)
  https://crrev.com/a6c0bfd3638afcdab3870fc06e38da7026f64a02 Add phajdan.jr@ to recipe roller gatekeeper (martiniss@chromium.org)
  https://crrev.com/9698e1fca3cdca11d25bdef82986b13ab37c24ca [WebView] Update CTS logic to load test name from json. (mikecase@chromium.org)

R=jbudorick@chromium.org,rnephew@chromium.org,mikecase@chromium.org,iannucci@chromium.org,estaab@chromium.org,martiniss@chromium.org
BUG= 634894 ,604882, 592140 ,633739

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2224463003

[modify] https://crrev.com/653ab70c50df6468b54af290a5e4ae2070067dbe/infra/config/recipes.cfg

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/653ab70c50df6468b54af290a5e4ae2070067dbe

commit 653ab70c50df6468b54af290a5e4ae2070067dbe
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Aug 05 19:05:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4a1518cbd73f73b7842e80603396746aa49468d2 [Android] Add recipe code to run chrome telemetry browser tests. (mikecase@chromium.org)
  https://crrev.com/448c0c7029e4f4d6cd8381032800c65fc839bca0 [Android] Run result_details logic in a finally block. (jbudorick@chromium.org)
  https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2 [Android] Pass known devices file path to host info to detect missing devices. (rnephew@chromium.org)
  https://crrev.com/e93a9b8a319982bbab04851673467a375ddd3730 [cronet] Update PERF_IDs for new builders. (jbudorick@chromium.org)
  https://crrev.com/ef300a91ffa556e0b7eeed363b926aeea9eb3a40 Revert of Removing old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2219653003/ ) (martiniss@chromium.org)
  https://crrev.com/a6c0bfd3638afcdab3870fc06e38da7026f64a02 Add phajdan.jr@ to recipe roller gatekeeper (martiniss@chromium.org)
  https://crrev.com/9698e1fca3cdca11d25bdef82986b13ab37c24ca [WebView] Update CTS logic to load test name from json. (mikecase@chromium.org)

R=jbudorick@chromium.org,rnephew@chromium.org,mikecase@chromium.org,iannucci@chromium.org,estaab@chromium.org,martiniss@chromium.org
BUG= 634894 ,604882, 592140 ,633739

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2224463003

[modify] https://crrev.com/653ab70c50df6468b54af290a5e4ae2070067dbe/infra/config/recipes.cfg

Project Member

Comment 48 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4b7c8e0dd470d54346abab2446b497ae34bf3c9

commit b4b7c8e0dd470d54346abab2446b497ae34bf3c9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Aug 05 19:22:31 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/448c0c7029e4f4d6cd8381032800c65fc839bca0 [Android] Run result_details logic in a finally block. (jbudorick@chromium.org)
  https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2 [Android] Pass known devices file path to host info to detect missing devices. (rnephew@chromium.org)
  https://crrev.com/e93a9b8a319982bbab04851673467a375ddd3730 [cronet] Update PERF_IDs for new builders. (jbudorick@chromium.org)
  https://crrev.com/ef300a91ffa556e0b7eeed363b926aeea9eb3a40 Revert of Removing old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2219653003/ ) (martiniss@chromium.org)
  https://crrev.com/a6c0bfd3638afcdab3870fc06e38da7026f64a02 Add phajdan.jr@ to recipe roller gatekeeper (martiniss@chromium.org)

R=iannucci@chromium.org,estaab@chromium.org,jbudorick@chromium.org,rnephew@chromium.org,martiniss@chromium.org
BUG= 634894 , 592140 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2212203003
Cr-Commit-Position: refs/heads/master@{#410139}

[modify] https://crrev.com/b4b7c8e0dd470d54346abab2446b497ae34bf3c9/infra/config/recipes.cfg

Project Member

Comment 49 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/613384915b046fb43c05c7bbcfcf0d8e93dfa515

commit 613384915b046fb43c05c7bbcfcf0d8e93dfa515
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Aug 05 21:48:45 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/448c0c7029e4f4d6cd8381032800c65fc839bca0 [Android] Run result_details logic in a finally block. (jbudorick@chromium.org)
  https://crrev.com/47e92bc8f5032a745175810c0f7096e4b3d7d3b2 [Android] Pass known devices file path to host info to detect missing devices. (rnephew@chromium.org)
  https://crrev.com/e93a9b8a319982bbab04851673467a375ddd3730 [cronet] Update PERF_IDs for new builders. (jbudorick@chromium.org)
  https://crrev.com/ef300a91ffa556e0b7eeed363b926aeea9eb3a40 Revert of Removing old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2219653003/ ) (martiniss@chromium.org)
  https://crrev.com/a6c0bfd3638afcdab3870fc06e38da7026f64a02 Add phajdan.jr@ to recipe roller gatekeeper (martiniss@chromium.org)
  https://crrev.com/9698e1fca3cdca11d25bdef82986b13ab37c24ca [WebView] Update CTS logic to load test name from json. (mikecase@chromium.org)

R=jbudorick@chromium.org,rnephew@chromium.org,iannucci@chromium.org,estaab@chromium.org,mikecase@chromium.org,martiniss@chromium.org
BUG= 634894 , 592140 ,633739

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2217313002
Cr-Commit-Position: refs/heads/master@{#410174}

[modify] https://crrev.com/613384915b046fb43c05c7bbcfcf0d8e93dfa515/infra/config/recipes.cfg

Sign in to add a comment