New issue
Advanced search Search tips

Issue 592126 link

Starred by 2 users
Status: Verified
Owner:
tguilbert@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up code to use VideoFrameMetadata::MergeMetadataFrom() when appropriate.

Project Member Reported by tguilbert@chromium.org, Mar 4 2016 
The fix to  issue 591138  has led to the introduction of a new utility method
to merge metadata between video frames.

There are a few instances through the codebase where the VideoFrameMetadata
is being serialized and de-serialized in order to merge the metadata to new 
video frames.

This issue tracks the work to replace the manual merging of the dictionary
values with the new cleaner utility function.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d

commit 8bec217c6d06d0aa60f1a15a24dfef6419fcb57d
Author: peary2 <peary2@gmail.com>
Date: Fri Sep 30 01:20:04 2016

Clean up code to use VideoFrameMetadata::MergeMetadataFrom() when appropriate.

This issue tracks the work to replace the manual merging of
the dictionary values with the new cleaner utility function.

This patch is replaced the 'VideoFrameMetadata::MergeInternalValuesInto()' and
'VideoFrameMetadata::MergeInternalValuesFrom()' to
'VideoFrameMetadata::MergeMetadataFrom()'.

BUG= 592126 

Review-Url: https://codereview.chromium.org/2380673002
Cr-Commit-Position: refs/heads/master@{#422007}

[modify] https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d/media/base/video_frame_unittest.cc
[modify] https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d/media/renderers/skcanvas_video_renderer.cc

Comment 2 by tguilbert@chromium.org, Oct 6 2016

Status: Verified (was: Assigned)
Thanks for the fix!
►

Sign in to add a comment