Implement MojoDemuxerStream::EnableBitstreamConverter |
||
Issue descriptionWe need to enable it for AAC and H264 on chromecast hardware decoders. The current CmaRenderer enables the bitstream converter here: https://code.google.com/p/chromium/codesearch#chromium/src/chromecast/renderer/media/cma_renderer.cc&sq=package:chromium&q=cmarender&l=278 https://code.google.com/p/chromium/codesearch#chromium/src/chromecast/renderer/media/cma_renderer.cc&sq=package:chromium&q=cmarender&l=342 It might simply be a matter of adding this API to media.interfaces.DemuxerStream.
,
Mar 7 2016
While it may be quite easy to simply expose media::DemuxerStream::EnableBitstreamConverter as a mojo media.interfaces.DemuxerStream API, but I find EnableBitstreamConverter interface a bit weird: There is no way to disable BitStreamConverter once enabled. While the current renderers/decoders enable it based on the current decoder config, it seems to be designed with the assumption that a particular decoder will always need it irrespective of the type of decoder config. In fact FFmpegDemuxerStream::InitBitstreamConverter already checks the codec if and enables it for only AAC, H264, and HEVC. It might make sense to just add media::DemuxerStream::Initialize(bool enable_bitstream_converter) and let the implementation for DemuxerStream handle enable/disable bitstream conversion internally.
,
Mar 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/198d663363a342e390d57e789558e66fd63ef800 commit 198d663363a342e390d57e789558e66fd63ef800 Author: alokp <alokp@chromium.org> Date: Tue Mar 08 18:06:10 2016 Plumb DemuxerStream::EnableBitstreamConverter through mojo pipeline. BUG= 592114 Review URL: https://codereview.chromium.org/1774763002 Cr-Commit-Position: refs/heads/master@{#379856} [modify] https://crrev.com/198d663363a342e390d57e789558e66fd63ef800/chromecast/browser/media/cast_renderer.cc [modify] https://crrev.com/198d663363a342e390d57e789558e66fd63ef800/media/mojo/interfaces/demuxer_stream.mojom [modify] https://crrev.com/198d663363a342e390d57e789558e66fd63ef800/media/mojo/services/mojo_demuxer_stream_adapter.cc [modify] https://crrev.com/198d663363a342e390d57e789558e66fd63ef800/media/mojo/services/mojo_demuxer_stream_impl.cc [modify] https://crrev.com/198d663363a342e390d57e789558e66fd63ef800/media/mojo/services/mojo_demuxer_stream_impl.h
,
Mar 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by xhw...@chromium.org
, Mar 5 2016