Incorrect popup message after installing extension
Reported by
jleedev@gmail.com,
Mar 4 2016
|
|||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2667.0 Safari/537.36
Steps to reproduce the problem:
1. Create a bare minimum extension, e.g.
{"manifest_version":2,"name":"foo","version":"1"}
2. Pack this into a crx
3. Install the extension
What is the expected behavior?
What went wrong?
The message given is "This icon will be visible when the extension can act on the current page."
However, this extension cannot act on any page; it has no permissions, no browser action, and no page action.
Even a more complex extension that has permission to act on certain web pages but has no page/browser action will trigger this popup, and it just doesn't make sense.
This is a regression -- in 48, the popup message simply said something about how to find Tools > Extensions.
(If I had to guess, this is happening because the popup message was not expecting a toolbar icon to be created for such an extension.)
WebStore page:
Did this work before? Yes 48 stable
Chrome version: 51.0.2667.0 Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 21.0 r0
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a95746da777d05038504582018366c4738c5ae7 commit 0a95746da777d05038504582018366c4738c5ae7 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 09 18:32:57 2016 [Extensions] Update installed bubble for extensions with synthesized actions Extensions with synthesized actions shouldn't get the "How to use" text. BUG= 592106 Review URL: https://codereview.chromium.org/1778603003 Cr-Commit-Position: refs/heads/master@{#380161} [modify] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/browser/ui/extensions/extension_installed_bubble.cc [add] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc [modify] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/chrome_tests.gypi [modify] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/common/extensions/api/extension_action/action_info.cc [modify] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/common/extensions/api/extension_action/action_info.h [modify] https://crrev.com/0a95746da777d05038504582018366c4738c5ae7/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
,
Mar 9 2016
Should be fixed. Requesting merge to M50. We may also want to merge this to 49, but we'll let it bake a bit first.
,
Mar 10 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 10 2016
Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're close to M50 Beta candidate cut for next week. Thank you.
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d4995584e3203ae57a7010dc584fedc84fffe8e commit 1d4995584e3203ae57a7010dc584fedc84fffe8e Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 10 21:43:36 2016 [Extensions] Update installed bubble for extensions with synthesized actions Extensions with synthesized actions shouldn't get the "How to use" text. BUG= 592106 Review URL: https://codereview.chromium.org/1778603003 Cr-Commit-Position: refs/heads/master@{#380161} (cherry picked from commit 0a95746da777d05038504582018366c4738c5ae7) Review URL: https://codereview.chromium.org/1779343002 . Cr-Commit-Position: refs/branch-heads/2661@{#185} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/browser/ui/extensions/extension_installed_bubble.cc [add] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc [modify] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/chrome_tests.gypi [modify] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/common/extensions/api/extension_action/action_info.cc [modify] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/common/extensions/api/extension_action/action_info.h [modify] https://crrev.com/1d4995584e3203ae57a7010dc584fedc84fffe8e/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
,
Mar 16 2016
rdevlin.cronin@ Could you please provide any sample extension file to triage the issue from test team end. Tested the issue by using other sample crx file but not able to find the text "This icon will be visible when the extension can act on the current page." while adding the extension. Please find the attached screen shot fro the same.Tested on windows 7 using chrome version 49.0.2623.37 and 51.0.2667.0 Thanks, |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rdevlin....@chromium.org
, Mar 8 2016Status: Assigned (was: Unconfirmed)