USB tab indicator needed on desktop |
||||||||
Issue descriptionSecurity UX requests that when a site is using the WebUSB API to access a device there be an indicator in the tab. This is a blocker for shipping this API but not for launching an experiment.
,
Mar 7 2016
Thanks! Assign it back to me when the assets are available.
,
Mar 9 2016
I think the attached should do it. For future reference to myself, this is from the PSD in: Chrome ux specs and sources > Chrome Omnibox icons Which is quite a bit dated now. No cut image folder provided (hence they are attached.)
,
Mar 9 2016
(Note these were already in the PSD so they might be in the system already.)
,
Apr 4 2016
This will be implemented in M-52. In M-51 USB device connections will be disallowed from background tabs.
,
Apr 4 2016
rolfe@, do we need a vector icon as well? The Bluetooth tab indicator appears to be using one: https://codereview.chromium.org/1746333002
,
Apr 5 2016
I've confirmed vector icons are used everywhere other than OS X. It would be great to get this before the M-51 branch point as I have the rest of the patch written and tested.
,
Apr 5 2016
Material USB vector icon lives here: https://storage.googleapis.com/icons.google.com.a.appspot.com/google-assets/system_icons/quantum/device/res-export/ic_usb_24px.svg I'm a little rusty on desktop assets so if this isn't what you were expecting let me know.
,
Apr 5 2016
Patch out for review, looks like we'll make it for M-51. https://codereview.chromium.org/1857033003
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0 commit 3e1eacc3ed0445d768faec12f11d86b6b53ca1e0 Author: reillyg <reillyg@chromium.org> Date: Fri Apr 08 18:52:46 2016 Implement tab indicator for WebUSB. When a frame within a tab has a USB device open a tab indicator is displayed to alert the user to the ongoing connection. BUG= 592105 Review URL: https://codereview.chromium.org/1857033003 Cr-Commit-Position: refs/heads/master@{#386151} [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/generated_resources.grd [add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/default_100_percent/legacy/tab_usb_indicator.png [add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/default_200_percent/legacy/tab_usb_indicator.png [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/ui/tabs/tab_utils.h [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/usb_tab_helper.cc [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/usb_tab_helper.h [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/web_usb_permission_provider.cc [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/web_usb_permission_provider.h [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/device_impl.cc [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/mock_permission_provider.h [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/permission_provider.h [modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/ui/gfx/BUILD.gn [add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/ui/gfx/vector_icons/tab_usb_connected.icon
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c3ab3d07108f906137537c771de9b5bda0ef83c commit 4c3ab3d07108f906137537c771de9b5bda0ef83c Author: reillyg <reillyg@chromium.org> Date: Fri Apr 08 22:11:54 2016 Remove page visibility requirement for WebUSB. Now that there is a tab indicator for WebUSB it can be used from a tab that is not in the foreground. BUG= 595375 , 592105 Review URL: https://codereview.chromium.org/1857393002 Cr-Commit-Position: refs/heads/master@{#386221} [delete] https://crrev.com/0992e8345174e4f16c6949a7982125ee82455b61/third_party/WebKit/LayoutTests/usb/disconnect-when-hidden-or-closed.html [modify] https://crrev.com/4c3ab3d07108f906137537c771de9b5bda0ef83c/third_party/WebKit/Source/modules/webusb/USBDevice.cpp [modify] https://crrev.com/4c3ab3d07108f906137537c771de9b5bda0ef83c/third_party/WebKit/Source/modules/webusb/USBDevice.h
,
Apr 8 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rolfe@chromium.org
, Mar 7 2016Owner: rolfe@chromium.org