New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592105 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 492204



Sign in to add a comment

USB tab indicator needed on desktop

Project Member Reported by reillyg@chromium.org, Mar 4 2016

Issue description

Security UX requests that when a site is using the WebUSB API to access a device there be an indicator in the tab. This is a blocker for shipping this API but not for launching an experiment.
 

Comment 1 by rolfe@chromium.org, Mar 7 2016

Cc: -rolfe@chromium.org reillyg@chromium.org
Owner: rolfe@chromium.org
Assigning to me to cut the icon for you if that's OK.
Thanks! Assign it back to me when the assets are available.

Comment 3 by rolfe@chromium.org, Mar 9 2016

Cc: -reillyg@chromium.org rolfe@chromium.org
Owner: reillyg@chromium.org
I think the attached should do it.

For future reference to myself, this is from the PSD in:
Chrome ux specs and sources > Chrome Omnibox icons
Which is quite a bit dated now. No cut image folder provided (hence they are attached.)
omnibox_usb_1x.png
349 bytes View Download
omnibox_usb_2x.png
494 bytes View Download

Comment 4 by rolfe@chromium.org, Mar 9 2016

(Note these were already in the PSD so they might be in the system already.)
Labels: -M-51 M-52
This will be implemented in M-52. In M-51 USB device connections will be disallowed from background tabs.
Labels: Needs-Feedback
rolfe@, do we need a vector icon as well? The Bluetooth tab indicator appears to be using one: https://codereview.chromium.org/1746333002
Cc: -rolfe@chromium.org reillyg@chromium.org
Labels: -Needs-Feedback
Owner: rolfe@chromium.org
I've confirmed vector icons are used everywhere other than OS X. It would be great to get this before the M-51 branch point as I have the rest of the patch written and tested.

Comment 8 by rolfe@chromium.org, Apr 5 2016

Material USB vector icon lives here:
https://storage.googleapis.com/icons.google.com.a.appspot.com/google-assets/system_icons/quantum/device/res-export/ic_usb_24px.svg

I'm a little rusty on desktop assets so if this isn't what you were expecting let me know.
Cc: -reillyg@chromium.org rolfe@chromium.org
Labels: -M-52 M-51
Owner: reillyg@chromium.org
Status: Started (was: Assigned)
Patch out for review, looks like we'll make it for M-51.

https://codereview.chromium.org/1857033003
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0

commit 3e1eacc3ed0445d768faec12f11d86b6b53ca1e0
Author: reillyg <reillyg@chromium.org>
Date: Fri Apr 08 18:52:46 2016

Implement tab indicator for WebUSB.

When a frame within a tab has a USB device open a tab indicator is
displayed to alert the user to the ongoing connection.

BUG= 592105 

Review URL: https://codereview.chromium.org/1857033003

Cr-Commit-Position: refs/heads/master@{#386151}

[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/generated_resources.grd
[add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/default_100_percent/legacy/tab_usb_indicator.png
[add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/default_200_percent/legacy/tab_usb_indicator.png
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/ui/tabs/tab_utils.h
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/usb_tab_helper.cc
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/usb_tab_helper.h
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/web_usb_permission_provider.cc
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/chrome/browser/usb/web_usb_permission_provider.h
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/device_impl.cc
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/mock_permission_provider.h
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/device/usb/mojo/permission_provider.h
[modify] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/ui/gfx/BUILD.gn
[add] https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0/ui/gfx/vector_icons/tab_usb_connected.icon

Status: Fixed (was: Started)
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment