New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592104 link

Starred by 3 users
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Mar 2016
Cc:
█ phoglund@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup: remove prefix "chrome" of files chrome/browser/media/chrome_*

Project Member Reported by mcasas@chromium.org, Mar 4 2016 
Is unneeded, probably is there from a previous reshuffling
of files.

Affected files:

ll chrome/browser/media/chrome_*
-rw-r--r--  1 mcasas   4548 Jan  7 14:41 chrome/browser/media/chrome_webrtc_webcam_browsertest.cc
-rw-r--r--  1 mcasas  14505 Jan  7 14:41 chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
-rw-r--r--  1 mcasas   2826 Feb 10 10:16 chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc
-rw-r--r--  1 mcasas   7430 Dec 21 15:18 chrome/browser/media/chrome_webrtc_perf_browsertest.cc
-rw-r--r--  1 mcasas  11277 Nov 19 17:47 chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc
-rw-r--r--  1 mcasas   3590 Jan  7 14:41 chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc
-rw-r--r--  1 mcasas   4204 Feb 26 14:59 chrome/browser/media/chrome_webrtc_browsertest.cc
-rw-r--r--  1 mcasas  33763 Jan  7 14:41 chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc
-rw-r--r--  1 mcasas  12270 Feb 10 10:16 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
-rw-r--r--  1 mcasas   6606 Jan  7 14:41 chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30

commit d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30
Author: mcasas <mcasas@chromium.org>
Date: Fri Mar 11 17:35:59 2016

Cleanup: remove prefix chrome_ of chrome/browser/media/chrome* files

Note how the name of the tests inside the files
respect the new naming, and not the chrome_ prefixed.

Done in two moves:
$ for i in `ls chrome_*`; do git mv $i `echo $i | sed -e 's/chrome_//'`; done
$ tools/git/mass-rename.py

No new code whatsoever.

BUG= 592104 

Review URL: https://codereview.chromium.org/1762413002

Cr-Commit-Position: refs/heads/master@{#380662}

[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/media_stream_infobar_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_apprtc_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_audio_quality_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_disable_encryption_flag_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_getmediadevices_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_perf_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_simulcast_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_video_quality_browsertest.cc
[rename] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/browser/media/webrtc_webcam_browsertest.cc
[modify] https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30/chrome/chrome_tests.gypi

Comment 2 by mcasas@chromium.org, Mar 11 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f912749c71106cd7e385a8aca0901c6b0312154

commit 7f912749c71106cd7e385a8aca0901c6b0312154
Author: mbjorge <mbjorge@chromium.org>
Date: Thu Apr 14 01:09:25 2016

Cleanup: remove prefix chrome_ of chrome/browser/media/chrome* files

BUILD.gn was missed in the original clean up in
https://codereview.chromium.org/1762413002

BUG= 592104 

Review URL: https://codereview.chromium.org/1885863005

Cr-Commit-Position: refs/heads/master@{#387183}

[modify] https://crrev.com/7f912749c71106cd7e385a8aca0901c6b0312154/chrome/test/BUILD.gn
►

Sign in to add a comment