Consider removing SQLITE_NO_SYNC |
|||
Issue description
third_party/sqlite/sqlite.gyp (and related gn file) contains this:
[ 'chromeos==1' , {
'defines': [
# Despite obvious warnings about not using this flag in
# deployment, we are turning off sync in ChromeOS and relying on
# the underlying journaling filesystem to do error recovery
# properly. It's much faster.
'SQLITE_NO_SYNC',
],
}],
bug 455749 implies that this might not be entirely safe.
We should:
1: Investigate if SQLITE_NO_SYNC is really safe today.
2: If it isn't, either make it safe or remove it.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d53cc59b6781b26babf0721fc9c001a32b3dada8 commit d53cc59b6781b26babf0721fc9c001a32b3dada8 Author: afakhry <afakhry@chromium.org> Date: Mon May 09 23:45:36 2016 Remove SQLITE_NO_SYNC on Chrome OS We agreed to remove this flag as the underlying FS doesn't seem to be able to reliably recover from corruption when a crash or panic occurs (see crbug.com/502898). BUG= 592101 TEST= Check the "Profile.ProfileError" metric to determine the impact of this flag removal. Review-Url: https://codereview.chromium.org/1961823003 Cr-Commit-Position: refs/heads/master@{#392477} [modify] https://crrev.com/d53cc59b6781b26babf0721fc9c001a32b3dada8/third_party/sqlite/BUILD.gn [modify] https://crrev.com/d53cc59b6781b26babf0721fc9c001a32b3dada8/third_party/sqlite/sqlite.gyp
,
May 10 2016
We'll need to monitor the "Profile.ProfileError" metric.
,
May 23 2016
Bulk verified |
|||
►
Sign in to add a comment |
|||
Comment 1 by afakhry@chromium.org
, May 6 2016Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)