New issue
Advanced search Search tips

Issue 592096 link

Starred by 4 users
Status: Verified
Owner:
xiy...@chromium.org
Closed: Mar 2016
Cc:
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 455749



Sign in to add a comment

Call sync after data is updated on login.

Project Member Reported by abodenha@chromium.org, Mar 4 2016 
Background:
There are a number of circumstances where the system is particularly vulnerable to hard power cut or kernel crash (see  bug 455749 ). One is after login, especially on new account setup. Data is written to the profile but is cached for a long time before being written to disk.

One repro case:
1: Powerwash, sign in.
2: Crash the kernel soon after sign in.

This will trigger  bug 455749 .

This can never be completely 'fixed' but we can mitigate it.


What we want to do:
Once the bulk of filesystem operations are done on login we should issue a sync to flush everything to disk. The trick here is going to be in deciding exactly at what point to decide that we're "done".

Comment 1 by zea@chromium.org, Mar 4 2016 

Did you mean to add the Sync label here (which is specific to the Google Chrome sync service, not a filesystem sync)?

Comment 2 by abodenha@chromium.org, Mar 4 2016

Components: -Services>Sync
Typo sorry. Let me find a better component.

Comment 3 by abodenha@chromium.org, Mar 4 2016

Components: UI>Shell>StartScreen

Comment 4 by abodenha@chromium.org, Mar 8 2016

Labels: ReleaseBlock-Stable

Comment 5 by xiy...@chromium.org, Mar 18 2016

Cc: achuith@chromium.org
Status: Started (was: Assigned)
+achuith fyi

Proposed: https://codereview.chromium.org/1815853002/
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7131ebe0af4b20c6b0d8c138733cf944094e5adb

commit 7131ebe0af4b20c6b0d8c138733cf944094e5adb
Author: xiyuan <xiyuan@chromium.org>
Date: Tue Mar 22 19:22:07 2016

cros: Flush profile files at critical moments

- Add a FileFlusher helper to flush files under a given dir;
- Add ProfileHelper::FlushProfile to flush files for a given profile;
- FlushProfile after a user profile is loaded and again after merge session;
- FlushProfile if the signin profile is just created;
- Commit local state change upon user session starts, oauth status
  and force online signin flag is changed;

BUG= 592096 

Review URL: https://codereview.chromium.org/1815853002

Cr-Commit-Position: refs/heads/master@{#382632}

[add] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/base/file_flusher.cc
[add] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/base/file_flusher.h
[add] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/base/file_flusher_unittest.cc
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/profiles/profile_helper.cc
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/browser/chromeos/profiles/profile_helper.h
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/7131ebe0af4b20c6b0d8c138733cf944094e5adb/components/user_manager/user_manager_base.cc

Comment 7 by xiy...@chromium.org, Mar 22 2016

Status: Fixed (was: Started)

Comment 8 by shrawan@google.com, Jun 17 2016

Status: Verified (was: Fixed)
verified on 8172.56.0/51.0.2704.103 with Peach-pi, Lars, Cyan, Big and others.

Comment 9 Deleted

►

Sign in to add a comment