New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592091 link

Starred by 3 users
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 436217


Sign in to add a comment

canvas.getContext() should return a typedef rather than 'any'

Project Member Reported by junov@chromium.org, Mar 4 2016 
Our current implementation of HTMLCanvasElement.getContext() does not match the IDL in the spec for the return value.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8

commit 11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8
Author: junov <junov@chromium.org>
Date: Thu Mar 10 22:56:38 2016

Use a union typdef for the return type of canvas.getContext

This CL changes the IDL of getContext to match the specification

BUG= 592091 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1761003003

Cr-Commit-Position: refs/heads/master@{#380482}

[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/core/html/HTMLCanvasElement.idl
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[add] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
[add] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.h
[add] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.idl
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/11260a2fbc93d4ac6d6bb328b9c66c5fe1432fe8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

Comment 2 by junov@chromium.org, Mar 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment