New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592081 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Route launch spinner doesn't disappear if launch failed w/error.

Project Member Reported by apaci...@chromium.org, Mar 4 2016

Issue description

Repro:
1. Cast to a device immediately after unplugging it to generate an error.
2. When the error msg shows up, dismiss it.

The spinner next to the device continues for an indefinite amount of time after the error appears and is dismissed.

The spinner should stop when the error message relevant to the route creation appears.
 
We expect the route response to come back with an error, at which point the spinner will be cleared from the UI.  So it sounds more like the route response isn't coming back for some reason.
Cc: imch...@chromium.org
Talked to Vadim. The route response is resolved with a nondisplay route, but later the route creation fails and an issue is sent back from MRP to MR. 
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813d605e717ff246ea1bf65e11db6fbb4cf8679e

commit 813d605e717ff246ea1bf65e11db6fbb4cf8679e
Author: apacible <apacible@chromium.org>
Date: Tue Mar 22 19:36:00 2016

[Media Router WebUI] Clear pending route creation properties on error.

Sometimes, routes are created but initially "not for display". These are later resolved as "for display", then updated with an updated route list from the MRP to the WebUI.

Currently, when a route fails to resolve "for display", an issue is sent to the WebUI but no indication that the route creation had failed. This causes the sink that is currently "pending route launch" to show the spinner forever, rendering the rest of the sink list unable to create a route.

This change corresponds with a change in the MRP that makes use of the |routeId| field in an incoming issue and clears any pending route creation properties if the error corresponds to |pendingCreatedRouteId_|. This also renames |mediaRouteId| to |routeId| to be uniform with other references.

BUG= 592081 

Review URL: https://codereview.chromium.org/1807223003

Cr-Commit-Position: refs/heads/master@{#382640}

[modify] https://crrev.com/813d605e717ff246ea1bf65e11db6fbb4cf8679e/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/813d605e717ff246ea1bf65e11db6fbb4cf8679e/chrome/browser/resources/media_router/media_router_data.js

Status: Fixed (was: Started)

Sign in to add a comment