Issue metadata
Sign in to add a comment
|
14.9%-47.1% regression in blink_perf.svg at 379101:379136 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 5 2016
=== Auto-CCing suspected CL author dgozman@chromium.org === Hi dgozman@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Author : dgozman Commit description: Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} Commit : 924fe8af695e29594c55db971d793d4d931b337c Date : Thu Mar 03 22:19:29 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@379106 12.4272 0.337775 5 good chromium@379109 12.2592 0.297838 5 good chromium@379110 12.0616 0.102412 5 good chromium@379111 17.2362 1.352939 5 bad chromium@379115 16.5972 2.222161 5 bad chromium@379123 17.7486 1.549009 5 bad Bisect job ran on: winx64_10_perf_bisect Bug ID: 592077 Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests blink_perf.svg Test Metric: DropsOnABlade/DropsOnABlade Relative Change: 42.82% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/452 Job details: https://chromeperf.appspot.com/buildbucket_job_status/None | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 7 2016
This 'performance regression' is simply the revert of a temporary performance improvement. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lanwei@google.com
, Mar 4 2016