New issue
Advanced search Search tips

Issue 592068 link

Starred by 3 users
Status: Fixed
Owner:
jamiewa...@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Host settings lost on JID change

Project Member Reported by jamiewa...@chromium.org, Mar 4 2016 
What steps will reproduce the problem?
1. Connect to a host and change a setting (for example disable "Shrink to fit").
2. Restart the host (on Linux, this can be by running "killall -HUP chrome-remote-desktop-host"
3. Hit reconnect and check the options menu.

What is the expected output? What do you see instead?
Shrink to fit should still be disabled. Instead, it has reverted to the default (enabled) state, as have all other settings.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2fe1ad65044e955bd7184b7b9597de2162a6294

commit e2fe1ad65044e955bd7184b7b9597de2162a6294
Author: jamiewalch <jamiewalch@chromium.org>
Date: Sat Mar 05 00:34:04 2016

Load host settings in connect_ to ensure they are valid for every connection.

Previously, they were loaded only in start, which led to them being invalid
for reconnections where a JID change required that the host_ member be refreshed.

BUG= 592068 

Review URL: https://codereview.chromium.org/1765643003

Cr-Commit-Position: refs/heads/master@{#379414}

[modify] https://crrev.com/e2fe1ad65044e955bd7184b7b9597de2162a6294/remoting/webapp/crd/js/me2me_activity.js

Comment 2 by jamiewa...@chromium.org, Mar 7 2016

Labels: Merge-Request-50
Requesting merge to M50. This change only affects the Chromoting web-app; there are no changes to Chrome browser.

Comment 3 by tin...@google.com, Mar 7 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea40f3cc35b1b4782718e5b984dc0950ab2869d

commit 2ea40f3cc35b1b4782718e5b984dc0950ab2869d
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Mon Mar 07 21:16:26 2016

Load host settings in connect_ to ensure they are valid for every connection.

Previously, they were loaded only in start, which led to them being invalid
for reconnections where a JID change required that the host_ member be refreshed.

BUG= 592068 

Review URL: https://codereview.chromium.org/1765643003

Cr-Commit-Position: refs/heads/master@{#379414}
(cherry picked from commit e2fe1ad65044e955bd7184b7b9597de2162a6294)

Review URL: https://codereview.chromium.org/1769233002 .

Cr-Commit-Position: refs/branch-heads/2661@{#108}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/2ea40f3cc35b1b4782718e5b984dc0950ab2869d/remoting/webapp/crd/js/me2me_activity.js

Comment 5 by jamiewa...@chromium.org, Mar 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment