New issue
Advanced search Search tips

Issue 592063 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Wrong initial values for dimensions (width/height) on <symbol> referenced from <use>

Project Member Reported by f...@opera.com, Mar 4 2016

Issue description

The initial values for width/height on the <svg> generated for the <symbol> should be "100%".
 

Comment 1 by f...@opera.com, Mar 4 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/968291cbf64a457362eeaef67f380283541a2774

commit 968291cbf64a457362eeaef67f380283541a2774
Author: fs <fs@opera.com>
Date: Fri Mar 04 20:54:47 2016

Correct initial width/height for <use>d <symbol>s

The initial values for width/height on the <svg> generated for the
<symbol> should be "100%".
Since the <symbol> element had been replaced by a <svg> element by the
time the attributes were transferred the wrong set of rules were used.

Adjust svg/custom/use-attribute-invalidations.html to be correct.
svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml now
renders correctly.

BUG= 592063 

Review URL: https://codereview.chromium.org/1757993007

Cr-Commit-Position: refs/heads/master@{#379350}

[modify] https://crrev.com/968291cbf64a457362eeaef67f380283541a2774/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/968291cbf64a457362eeaef67f380283541a2774/third_party/WebKit/LayoutTests/svg/custom/use-attribute-invalidations.html
[add] https://crrev.com/968291cbf64a457362eeaef67f380283541a2774/third_party/WebKit/LayoutTests/svg/custom/use-symbol-initial-width-height-expected.html
[add] https://crrev.com/968291cbf64a457362eeaef67f380283541a2774/third_party/WebKit/LayoutTests/svg/custom/use-symbol-initial-width-height.html
[modify] https://crrev.com/968291cbf64a457362eeaef67f380283541a2774/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6128ed93accb47834f7e699ea98e0907c10a7153

commit 6128ed93accb47834f7e699ea98e0907c10a7153
Author: Walter Korman <wkorman@google.com>
Date: Mon Mar 07 19:55:57 2016

Auto-rebaseline for r379350

https://chromium.googlesource.com/chromium/src/+/968291cbf

BUG= 592063 
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/1773763002 .

Cr-Commit-Position: refs/heads/master@{#379617}

[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png
[modify] https://crrev.com/6128ed93accb47834f7e699ea98e0907c10a7153/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt

Comment 4 by f...@opera.com, Mar 7 2016

Status: Fixed (was: Started)

Sign in to add a comment