New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592058 link

Starred by 8 users
Status: Verified
Owner:
█ bruthig@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
ajha@chromium.org
█ rookrishna@chromium.org
sdantul...@chromium.org
█ tdander...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 505807



Sign in to add a comment

Add material-style mouse hover and ripple effects for menu hosting bookmark bar buttons

Project Member Reported by bruthig@chromium.org, Mar 4 2016 
Replace the existing mouse hover effects in bookmark bar buttons that host menus with the new material design-style hover effects.

Split from  issue 523058 .

Comment 1 by bruthig@chromium.org, Mar 4 2016

Summary: Add material-style mouse hover and ripple effects for menu hosting bookmark bar buttons (was: Add material-style mouse hover effects for menu hosting bookmark bar buttons)

Comment 3 by bruthig@chromium.org, Mar 4 2016

Cc: rookrishna@chromium.org tdander...@chromium.org sdantul...@chromium.org abod...@chromium.org
 Issue 551641  has been merged into this issue.

Comment 4 by tdander...@chromium.org, Mar 7 2016

Labels: -Pri-2 Pri-1

Comment 5 by keta...@chromium.org, Mar 8 2016 

bruthig@ is this issue beta blocking? Please update when ready for merge.

Comment 7 by keta...@chromium.org, Mar 9 2016 

bruthig@ - Please note that all merges into 50 for beta purpose should happen by monday the 14th.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ead9e2c8b5d650d7d72868ab10f147a86642b97

commit 3ead9e2c8b5d650d7d72868ab10f147a86642b97
Author: bruthig <bruthig@chromium.org>
Date: Fri Mar 11 14:20:50 2016

Moved AppMenu ACTIVATED/DEACTIVATED ink drop handling in to MenuButton.

The AppMenuButton and the ToolbarActionView buttons were both handling
the ink drop animating to/from the ACTIVATED/DEACTIVATED states. This
change pushes that logic up in the common ancestor MenuButton.

BUG= 592058 
TEST=MenuButtonTest.*
TEST=ToolbarActionViewUnitTest.NoCrashWhenDestroyingToolbarActionViewThatHasAPressedLock

Review URL: https://codereview.chromium.org/1778643002

Cr-Commit-Position: refs/heads/master@{#380626}

[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/chrome/browser/ui/views/toolbar/app_menu_button.h
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc
[add] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/animation/test/test_ink_drop_delegate.cc
[add] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/animation/test/test_ink_drop_delegate.h
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/3ead9e2c8b5d650d7d72868ab10f147a86642b97/ui/views/views.gyp
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5c17d7fd792247f8e852881f16a4d5ab228afb

commit db5c17d7fd792247f8e852881f16a4d5ab228afb
Author: bruthig <bruthig@chromium.org>
Date: Fri Mar 11 23:53:52 2016

Added ink drop hover/ripple to menu hosting bookmark buttons.

BUG= 592058 

TEST=InkDropAnimationControllerImplTest.*
TEST=InkDropAnimationTest.*
TEST=CustomButtonTest.InkDropAfterShowingContextMenu
TEST=CustomButtonTest.InkDropAfterTryingToShowContextMenu
TEST=Manual

Review URL: https://codereview.chromium.org/1757993004

Cr-Commit-Position: refs/heads/master@{#380786}

[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/button_ink_drop_delegate.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/button_ink_drop_delegate.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/flood_fill_ink_drop_animation.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/flood_fill_ink_drop_animation.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_controller.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_controller_factory.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/ink_drop_delegate.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/square_ink_drop_animation.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/square_ink_drop_animation.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/test/test_ink_drop_delegate.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/animation/test/test_ink_drop_delegate.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/controls/button/custom_button_unittest.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/db5c17d7fd792247f8e852881f16a4d5ab228afb/ui/views/controls/menu/menu_controller.cc

Comment 10 by bruthig@chromium.org, Mar 11 2016

Status: Fixed (was: Started)

Comment 11 by bruthig@chromium.org, Mar 12 2016

Labels: Merge-Request-50
Merge request for the following two CL's:
- https://codereview.chromium.org/1778643002
- https://codereview.chromium.org/1757993004

Comment 12 by tin...@google.com, Mar 12 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 13 by gov...@chromium.org, Mar 13 2016 

Please merge your change to M50 branch 2661 if you think it is a safe merge. If merge happens by Monday (03/14) 5:00 PM PST, we can take it in for next week beta. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 13 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1143984d47db7f25de36cebfcc5c189e0231f2a2

commit 1143984d47db7f25de36cebfcc5c189e0231f2a2
Author: Ben Ruthig <bruthig@chromium.org>
Date: Sun Mar 13 20:53:11 2016

Moved AppMenu ACTIVATED/DEACTIVATED ink drop handling in to MenuButton.

The AppMenuButton and the ToolbarActionView buttons were both handling
the ink drop animating to/from the ACTIVATED/DEACTIVATED states. This
change pushes that logic up in the common ancestor MenuButton.

BUG= 592058 
TEST=MenuButtonTest.*
TEST=ToolbarActionViewUnitTest.NoCrashWhenDestroyingToolbarActionViewThatHasAPressedLock

Review URL: https://codereview.chromium.org/1778643002

Cr-Commit-Position: refs/heads/master@{#380626}
(cherry picked from commit 3ead9e2c8b5d650d7d72868ab10f147a86642b97)

Review URL: https://codereview.chromium.org/1798523003 .

Cr-Commit-Position: refs/branch-heads/2661@{#207}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/chrome/browser/ui/views/toolbar/app_menu_button.h
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc
[add] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/animation/test/test_ink_drop_delegate.cc
[add] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/animation/test/test_ink_drop_delegate.h
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/1143984d47db7f25de36cebfcc5c189e0231f2a2/ui/views/views.gyp
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d430a564c7a944882e6435e39861429fc72cd5d

commit 0d430a564c7a944882e6435e39861429fc72cd5d
Author: Ben Ruthig <bruthig@chromium.org>
Date: Sun Mar 13 21:01:38 2016

Added ink drop hover/ripple to menu hosting bookmark buttons.

BUG= 592058 

TEST=InkDropAnimationControllerImplTest.*
TEST=InkDropAnimationTest.*
TEST=CustomButtonTest.InkDropAfterShowingContextMenu
TEST=CustomButtonTest.InkDropAfterTryingToShowContextMenu
TEST=Manual

Review URL: https://codereview.chromium.org/1757993004

Cr-Commit-Position: refs/heads/master@{#380786}
(cherry picked from commit db5c17d7fd792247f8e852881f16a4d5ab228afb)

Review URL: https://codereview.chromium.org/1796623002 .

Cr-Commit-Position: refs/branch-heads/2661@{#208}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/button_ink_drop_delegate.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/button_ink_drop_delegate.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/flood_fill_ink_drop_animation.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/flood_fill_ink_drop_animation.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_controller.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_controller_factory.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/ink_drop_delegate.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/square_ink_drop_animation.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/square_ink_drop_animation.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/test/test_ink_drop_delegate.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/animation/test/test_ink_drop_delegate.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/controls/button/custom_button_unittest.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/0d430a564c7a944882e6435e39861429fc72cd5d/ui/views/controls/menu/menu_controller.cc

Comment 16 by ajha@chromium.org, Mar 16 2016

Cc: ajha@chromium.org
Labels: Needs-Feedback
bruthig@: Could you please help in verifying this fix. Tried to verify the fix on Windows-7 on chrome version: 50.0.2661.37 but didn't observe any difference b/w 50.0.2661.26 and 50.0.2661.37.

Attached is the screen-cast of the same.
592058_BeforeFix.mp4
980 KB Download
592058_AfterFix.mp4
922 KB Download

Comment 17 by bruthig@chromium.org, Mar 16 2016 

You should see a difference on Bookmark Folder buttons and the Bookmark Overflow button.

Comment 18 by rookrishna@chromium.org, Jun 3 2016

Status: Verified (was: Fixed)
Chrome Os 53.0.2754.0/8406.0.0
►

Sign in to add a comment