New issue
Advanced search Search tips

Issue 592055 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Websocket inspect json message doesn't have a scrollbar

Reported by edrock...@gmail.com, Mar 4 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.75 Safari/537.36

Steps to reproduce the problem:
1. Open dev tools and go to the network tab
2. Click on a websocket connection
3. Click on a json message(might happen with other types too)

What is the expected behavior?
The message inspector should show a scrollbar when the tree is bigger then the view area.

What went wrong?
It doesn't allow you to scroll. The only option is to increase the size of your devtools window and then increase the size of the message inspector part.

Did this work before? N/A 

Chrome version: 49.0.2623.75  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 20.0 r0

See the attached picture for the exact spot.
 
bad chrome inspector.png
56.5 KB View Download

Comment 1 by alph@chromium.org, Mar 7 2016

Owner: alph@chromium.org
Status: Started (was: Unconfirmed)

Comment 2 by alph@chromium.org, Mar 7 2016

Labels: Merge-Request-50

Comment 4 by alph@chromium.org, Mar 8 2016

Status: Fixed (was: Started)
Thanks alph!

Comment 6 by tin...@google.com, Mar 8 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're very close to M50 Beta candidate cut. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 8 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde1b19ba10ea8100eaf21b9ca2bd26dda856135

commit cde1b19ba10ea8100eaf21b9ca2bd26dda856135
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Mar 08 19:51:32 2016

DevTools: Add scroll bar to the JSON view.

BUG= 592055 
NOTRY=true

Review URL: https://codereview.chromium.org/1769193002

Cr-Commit-Position: refs/heads/master@{#379626}
(cherry picked from commit a8b492eaa1e7175f76106736a6d61cc5c643a9e4)

Review URL: https://codereview.chromium.org/1771393003 .

Cr-Commit-Position: refs/branch-heads/2661@{#128}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/cde1b19ba10ea8100eaf21b9ca2bd26dda856135/third_party/WebKit/Source/devtools/front_end/network/networkPanel.css
[modify] https://crrev.com/cde1b19ba10ea8100eaf21b9ca2bd26dda856135/third_party/WebKit/Source/devtools/front_end/ui/emptyWidget.css

Sign in to add a comment