Very odd. Why is new_chrome.exe being run? Can you reproduce this?

I am not able to reproduce on the machine since I already selected "Allow Access" on the prompt, Tried to check on another machine with fresh install of Chrome canary and haven't seen the issue.

Also observed that I still see the "relaunch" option even after updating to latest version of Chrome canary i.e., 51.0.2667.0 and this is only on my corp windows 7 machine.

I also got this today.

There are at least three things happening here:

1. I believe that the firewall dialog is appearing due to mDNS. On system-level Chrome, we install a firewall rule during Chrome install so that users don't see this prompt. We can't do this for user-level Chrome (such as canary). Vitaly: do you know if something has changed recently that would cause Chrome to fire up mDNS at startup even if the firewall rules aren't present? Or did we decide way back that this is what we're going to do?

2. new_chrome.exe is being run. Did this happen to you, too, Will? I can't repro it, even if I back up a few builds and let an in-use update happen.

3. Chrome always says it needs to relaunch. pbommana: I'm guessing that you still have new_chrome.exe on disk. Could you attach the output of these three commands:

reg query HKEY_CURRENT_USER\Software\Google\Update\Clients\{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20} /s
reg query HKEY_CURRENT_USER\Software\Google\Update\ClientState\{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20} /s"
dir "%LOCALAPPDATA%\Google\Chrome SxS\Application"

Please also attach %TEMP%\chrome_installer.log. Thanks.

I think this is due to a bug in code that shipped only in 51.0.2666.0 and 51.0.2667.0. My canary self-repaired after the next update, so I don't think there's any action we need to take. Does anyone else impacted see differently?

Nothing was changed. That's expected for Canary as a user level install.
I don't think we need to fix anything here.

Okay, my new theory is that the bug caused chrome.exe to vanish, and Windows' link tracking service changed the shortcuts to point to new_chrome.exe. This is what led to the sudden firewall prompt, which is a red herring.

Firewall rules include full path to executable.
Maybe it's worth adding similar rule for new_chrome.exe, for system level install as well?

Chrome's shortcuts should never point to new_chrome.exe. We should do what we need to make sure this doesn't happen, and to fix up installs where it already has.

After an in-use update from 51.0.2665.0 --> 51.0.2667.0, the shortcuts may point to C:\Users\x\AppData\Local\Google\Chrome SxS\Temp\scoped_dir_x_x\new_chrome.exe instead of C:\Users\x\AppData\Local\Google\Chrome SxS\chrome.exe. The CL that caused this https://codereview.chromium.org/1666363002/ has been reverted, but shortcuts are still broken.

here it the broken .lnk file, before I manually deleted/fixed them. it's possible there will be evidence in there that windows automagically changed it, maybe?

Deleted: broken_lnk 2.8 KB

broken_lnk 2.8 KB View Download

 Issue 593141  has been merged into this issue.

 Issue 593141  has been merged into this issue.

 Issue 593141  has been merged into this issue.

 Issue 593167  has been merged into this issue.

 Issue 593167  has been merged into this issue.

 Issue 593167  has been merged into this issue.

 Issue 593167  has been merged into this issue.

 Issue 593167  has been merged into this issue.

According  Issue 593167 , it's in 50 and affect System level install as well.

This bug is totally different from  issue#593167 , Since this bug is more of broken shortcuts upon update. Where in  issue#593167  is more of getting the Windows firewall prompt. 
I would still consider this as Dev blocker for M51, Please correct me if I am wrong.

We know.  It can't be unduped until https://bugs.chromium.org/p/monorail/issues/detail?id=1099 is fixed.

Please ignore my comment 21.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff323ec5588d6e61a4267ab32251cf2310c84533

commit ff323ec5588d6e61a4267ab32251cf2310c84533
Author: fdoray <fdoray@chromium.org>
Date: Thu Mar 10 15:10:36 2016

Fix the path of Chrome shortcuts from the installer.

With this CL, the installer looks for shortcuts with a target path that
starts with the install directory and ends with *chrome.exe. It updates
all these shortcuts to point to the correct Chrome executable.

This will fix shortcuts broken by https://codereview.chromium.org/1666363002/,
which have a path that looks like this:
C:\Users\<user>\AppData\Local\Google\Chrome SxS\Temp\scoped_dir_<x>\new_chrome.exe

R=gab@chromium.org,grt@chromium.org
BUG= 592040 

Review URL: https://codereview.chromium.org/1780693002

Cr-Commit-Position: refs/heads/master@{#380405}

[modify] https://crrev.com/ff323ec5588d6e61a4267ab32251cf2310c84533/chrome/installer/setup/install.cc

With r380405, the installer looks for shortcuts pointing to |installation dir|(.*)chrome\.exe and updates them to point to the correct chrome.exe for the current installation. Unfortunately, for a user-level dev/beta/stable installation, |installation dir| is something like "C:\Users\...\Google\Chrome", which means that "C:\Users\...\Google\Chrome SxS\chrome.exe" is matched.

Issue described in comment 26 now has its own bug:  crbug.com/595374 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92470817cc0a5a126bc447e4777668f76b658497

commit 92470817cc0a5a126bc447e4777668f76b658497
Author: grt <grt@chromium.org>
Date: Thu Oct 27 19:30:20 2016

Remove shortcut path fixups introduced to repair breakages caused by r378802.

This reverts "Fix the path of Chrome shortcuts from the installer."
(04228a0), "Don't update Canary shortcuts from Dev/Beta/Stable
installer." (a310422), and "Fix the path of shortcuts with an icon in
the current install dir." (ff323ec).

BUG= 592040 , 595374 
R=fdoray@chromium.org

Review-Url: https://codereview.chromium.org/2456853002
Cr-Commit-Position: refs/heads/master@{#428110}

[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install.h
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/setup/install_unittest.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util.cc
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util.h
[modify] https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497/chrome/installer/util/install_util_unittest.cc