New issue
Advanced search Search tips

Issue 592031 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Expose api WebPluginContainer::localToScreenRect to retrieve plugin rect in screen coordinates

Project Member Reported by j.iso...@samsung.com, Mar 4 2016 
Version: 51.0.2668.0 (Developer Build) (64-bit)
OS: Linux

Currently in child class of blink::WebPlugin or WebViewPlugin::Delegate, it is not possible to query its position in screen coordinates.

Currently in WebPluginContainer there are:
virtual WebPoint rootFrameToLocalPoint(const WebPoint&) = 0;
virtual WebPoint localToRootFramePoint(const WebPoint&) = 0;

I suggest to add:
virtual WebRect localToScreenRect(const WebRect&) = 0;

So that an plugin can call
rect_in_screen_coords = plugin()->container()->localToScreenRect(unobscured_rect)
when its WebViewPlugin::updateGeometry is called.

Comment 1 by j.iso...@samsung.com, Mar 4 2016 

If interested here is my suggested CL: https://codereview.chromium.org/1763103002/

Comment 2 by j.iso...@samsung.com, Mar 29 2016

Labels: -GPU-Other Blink
Status: WontFix (was: Untriaged)
Hi, I realized that localToRootFramePoint is enough since I can compute rootFrame point to screen coordinates from the app itself. Since the app owns the web view and it knows its position on the screen.

So adding localToScreenRect is unnecessary and now I think it should never be necessary. Because an application should be able to retrieve its position on the screen.
►

Sign in to add a comment