New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592015 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 586384



Sign in to add a comment

Windows 8 Debug GPU FYI bot failing WebGL video tests

Project Member Reported by jmad...@chromium.org, Mar 4 2016

Issue description

First failing build:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Debug%20%28NVIDIA%29/builds/11936

Regression range:

https://chromium.googlesource.com/chromium/src/+log/643dba13a5f5af08e4aed492eac3411495361360..dd0212bf1ded527ef727fe2f2647186b472c379e

Failing tests:

WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8_red_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r32f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8ui_red_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8_rg_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg32f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8ui_rg_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rgb8_rgb_unsigned_byte

WebglConformance.conformance_extensions_oes_texture_float_with_video
WebglConformance.conformance_extensions_oes_texture_half_float_with_video
WebglConformance.conformance_textures_misc_texture_upload_size
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_short_5_6_5
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_5_5_5_1

Suspecting 028d76aa627788a7252fd6de39304f67e00837ab. Going to revert and see if that cleans it up. Only seems to happen on this config.
 
Blocking: 586384
Yea, my patch is likely at fault now that look at the errors more carefully. 

[3372:3560:0303/221556:ERROR:gpu_video_decode_accelerator_host.cc(98)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8bbe7a881d08b2ae03312c6f3165257e37fd959

commit c8bbe7a881d08b2ae03312c6f3165257e37fd959
Author: jmadill <jmadill@chromium.org>
Date: Fri Mar 04 16:23:06 2016

Revert of Decouple Media Service (patchset #22 id:420001 of https://codereview.chromium.org/1736643005/ )

Reason for revert:
Likely causing Windows 8 Debug GPU FYI WebGL video test failures.

First failing build:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Debug%20%28NVIDIA%29/builds/11936

Regression range:

https://chromium.googlesource.com/chromium/src/+log/643dba13a5f5af08e4aed492eac3411495361360..dd0212bf1ded527ef727fe2f2647186b472c379e

Failing tests:

WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8_red_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r32f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8ui_red_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8_rg_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg32f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8ui_rg_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rgb8_rgb_unsigned_byte

WebglConformance.conformance_extensions_oes_texture_float_with_video
WebglConformance.conformance_extensions_oes_texture_half_float_with_video
WebglConformance.conformance_textures_misc_texture_upload_size
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_short_5_6_5
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_5_5_5_1

BUG= 592015 

Original issue's description:
> Decouple Media Service
>
> This CL moves media object creation IPCs into a separate
> MediaChannel object that lives above GpuChannel.
>
> content/gpu (or mus in the future) becomes the layer that
> lives above both gpu and media and glues the two together.
>
> This may not reflect what a hypothetical future mojo
> interface might look like. If we want to preserve the
> ordering guarantees we have now, media interfaces should be
> associated interfaces that branch off a gpu channel and its
> gpu interfaces. This seems to suggest that gpu should know
> about media or else there should exist a factory interface
> that glues both media and gpu as we have here.
>
> I don't want to block this CL on long term mojo interface
> discussions as any direction we choose is just a refactor
> away. Until then, in the interest of making forward
> progress, I'd like to assume there exists a layer above
> both media and gpu.
>
> Thoughts?
>
> BUG= 586384 
>
> Committed: https://crrev.com/028d76aa627788a7252fd6de39304f67e00837ab
> Cr-Commit-Position: refs/heads/master@{#379211}

TBR=dcheng@chromium.org,piman@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 586384 

Review URL: https://codereview.chromium.org/1767673002

Cr-Commit-Position: refs/heads/master@{#379297}

[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/content_message_generator.h
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/client/gpu_jpeg_decode_accelerator_host.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/client/gpu_video_encode_accelerator_host.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_channel.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_channel.h
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_command_buffer_stub.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_command_buffer_stub.h
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/gpu_messages.h
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/create_video_encoder_params.cc
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/create_video_encoder_params.h
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/media/gpu_jpeg_decode_accelerator.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/media/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/media/gpu_video_encode_accelerator.cc
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/media_channel.cc
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/media_channel.h
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/media_service.cc
[delete] https://crrev.com/146970c35843f0703fe36bdc4a88db40675f8c8d/content/common/gpu/media/media_service.h
[rename] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/media_messages.cc
[rename] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/common/gpu/media_messages.h
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/content_common.gypi
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959/content/gpu/gpu_child_thread.h

Status: Fixed (was: Assigned)
Tests started passing with the revert.

Sign in to add a comment